KAYAK-3391 RecordStream.processingAndCommitting #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val offsets = c.foldLeft(Map.empty[TopicPartition, Long])(_ ++ _._1) | ||
| val nextOffsets = | ||
| offsets.view.mapValues(o => new OffsetAndMetadata(o + 1)).toMap | ||
| println( |
There was a problem hiding this comment.
Should this println be removed, or replaced with proper logging?
There was a problem hiding this comment.
Definitely removed 😄 this is some experimental code to try out Stream.groupWithin. Will clean up before merge.
OddKristensen
approved these changes
Jan 17, 2024
rossabaker
reviewed
Jan 17, 2024
Comment on lines
216
to
217
| maxRecordCount: Long = 1000L, | ||
| maxElapsedTime: FiniteDuration = 60.seconds, |
There was a problem hiding this comment.
I don't think default args in an anonymous implementation will do anything but maybe get out of sync?
There was a problem hiding this comment.
Yeah these default args everywhere are a bit weird. Removed from the 2 impls in 43345d5.
|
Local testing in 2 real services went well, so going to merge this, cut a release, and continue testing. Can definitely make any needed followup changes in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAYAK-3391 Refactors
ConsumerOps.processingAndCommittingto be very generic. Also adds a batched implementation.Adds
processingAndCommittingto theRecordStreamabstraction, and implements it for both chunked (i.e. one-at-a-time) and batched record streams.Note that batched
processingAndCommittingsimply processes the entire batch, and if that succeeds then it updates the state to include that successfully processed batch's offsets. Only offsets for records in successfully processed batches will be committed. It does not try to do fancy things like handle partially succeeding (and failing) batches, or try to update state with individual records' offsets as they are processed. Note that if a batch fails processing, none of the offsets in that batch will be committed. This will lead to more reprocessing after startup, but hey this is at-least-once and your processing is idempotent, right?