KAYAK-3381 replace sendAsync with send #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmjohnsonjh
force-pushed
the
KAYAK-3381
branch
from
eaca1be to
43e7b78
Compare
zcox
approved these changes
Feb 15, 2024
|
This change will impact the conversations-settings class SettingsDebezium, which also uses this (as well as the conversations-video-chat-event-interceptor). If it is desirable to keep the fire-and-forget implementation it could be renamed. It's my impression that the "to" method should use the "send" implementation which is the basis for this change. |
amohrland
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.