Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Bloom filter: TODO "union", "intersect", and "clone config" #26

Open
rogerdielrton opened this issue Dec 17, 2015 · 3 comments
Open

Comments

@rogerdielrton
Copy link

Please, could you implemente these three features?

package orestes.bloomfilter.memory;
public class CountingBloomFilterMemory<T> implements CountingBloomFilter<T> {
    @Override
    public boolean union(BloomFilter<T> other) {
        //TODO
        throw new UnsupportedOperationException();
    }
    @Override
    public boolean intersect(BloomFilter<T> other) {
        //TODO
        throw new UnsupportedOperationException();
    }
}
public class BloomFilterMemory<T> implements BloomFilter<T> {
    @Override
    @SuppressWarnings("unchecked")
    public synchronized BloomFilter<T> clone() {
        BloomFilterMemory<T> o = null;
        try {
            o = (BloomFilterMemory<T>) super.clone();
        } 
        catch (CloneNotSupportedException e) {
            e.printStackTrace();
        }
        o.bloom = (BitSet) bloom.clone();
        //TODO clone config
        return o;
    }
@DivineTraube
Copy link
Contributor

Hi, this is on the roadmap, we hope to have it soon.

@EdwardRaff
Copy link

Is there an ETA for these functions?

@fbuecklers
Copy link
Member

fbuecklers commented Jan 19, 2017

We are sorry, but we can not estimate any ETA up to now.
But feel free to provide a pull request.

Btw: The BloomFilterMemory can already be cloned. The TODO was just not removed from the code. That the config is not cloned is a wanted behavior.

Best

cw124 added a commit to cw124/Orestes-Bloomfilter that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants