Make NEW_ROOM callback be prioritized #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes strange interactions with other mods by making sure the player's position is updated before they run their new room code
budjmt
reviewed
Mar 16, 2024
| @@ -373,7 +373,7 @@ function BasementRenovator.RenderDoorSlots(room, doorSlots, enterSlot) | |||
| end | |||
| end | |||
|
|
|||
| BasementRenovator.mod:AddCallback(ModCallbacks.MC_POST_NEW_ROOM, function() | |||
| BasementRenovator.mod:AddPriorityCallback(ModCallbacks.MC_POST_NEW_ROOM, CallbackPriority.IMPORTANT, function() | |||
There was a problem hiding this comment.
Since BR is technically supposed to work with the different versions of the game (although it's best effort right now) when using rep only APIs I've been gating them behind checks: b4ffe88#diff-09679ecfabcf35045938309e4229f4c96e65f8392a5b1b6f643aeb53ee16ecf4R211
Could you create some kind of wrapper for AddPriorityCallback that just uses AddCallback when it's not available?
|
closing since guwahavel is not responding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes strange interactions with other mods by making sure the player's position is updated before they run their new room code