Add option to append template to existing config

[egvimo]

My first draft for the option to append template to existing config file in silent mode.

Closes #1720

[egvimo]

What also bothers me a bit is that the two options no-modify-config and append-to-config are only used when the option silent is active.

It would be better, in my opinion, if the silent option is completely omitted and implicit by the other two options.

Maybe this can be achieved by another PR.

What do you think?

[NoahGorny]

What also bothers me a bit is that the two options no-modify-config and append-to-config are only used when the option silent is active.

It would be better, in my opinion, if the silent option is completely omitted and implicit by the other two options.

Maybe this can be achieved by another PR.

What do you think?

We can always keep and append if the option is specified, even if in interactive mode. This will make more sense of the config. Not sure we want to make it implicit, I prefer more explicit approach, esp in installations

[egvimo]

Now I have come to test my changes and write tests.

Unfortunately I'm getting a illegal option -- a error and I have no idea why. Did I miss some configuration?

[egvimo]

I found my mistake and corrected it.

Now the feature can be merged, if the review is passed. ;)

[NoahGorny]

hey @egvimo
I left you a comment, lemme know what you think!

[NoahGorny]

you can remove the while ! [ $silent ] check in line 150 in favor of while ! [ $append_to_config ], and remove [[ silent ]] check here. This will cause interactive mode to also automatically append if the option is specified

[egvimo]

@NoahGorny I've done the changes from your comment.

[NoahGorny]

Great job @egvimo !
You put a lot of effort into your PRs and I wanna say thank you for your help 😄
Also thanks @cornfeedhobo for the CR 😸