PR regarding bug #453 #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BACKUP_FILE=$CONFIG_FILE.bak | ||
|
|
||
| if [ -e $HOME/$BACKUP_FILE ]; then | ||
| echo "Backup file already exist. Make sure to backup your .bashrc before running this installation." >&2 |
There was a problem hiding this comment.
It should be "exists" instead of "exist".
|
Thanks for providing the PR, looks great! I've added some comments for a couple of minor things to fix/adjust. |
|
Thanks a lot for commenting. I'll provide a fixed PR later. |
shaief
added a commit
to shaief/bash-it
that referenced
this pull request
Apr 21, 2015
|
I close this PR and submit a new one. Thanks! |
…tion script ends.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reported this bug yesterday, and thought i should provide a pull request to fix it, so here it is.
I added a confirmation dialogue to verify that the user knows that their .bak file will be deleted in the process.
I also added a message to the user at the end of the script.
Thank you for writing and maintaining bash-it!