Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in combining preempt with enumeration-based inference in Pyro #248

Open
eb8680 opened this issue Sep 4, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working module:explainable

Comments

@eb8680
Copy link
Contributor

eb8680 commented Sep 4, 2023

In the course of working on #240 and #236, @rfl-urbaniak ran into problems when attempting to use infer_discrete and TraceEnum_ELBO in conjunction with causation and explanation queries defined via chirho.counterfactual.ops.preempt. This issue tracks progress on diagnosing and fixing those problems.

@eb8680 eb8680 added bug Something isn't working module:explainable labels Sep 4, 2023
@eb8680
Copy link
Contributor Author

eb8680 commented Sep 4, 2023

@rfl-urbaniak it's been a few weeks since you showed us this, and I'm afraid I've lost track of the context since then. Could you please create a failing test that illustrates this behavior and paste it here or push it to a branch in this repository and put a link to the branch here? Once you do that I will work on a fix.

@rfl-urbaniak
Copy link
Collaborator

A pytest test capturing the problem is now available in #253, also listed in the main description of that PR.

@rfl-urbaniak
Copy link
Collaborator

@eb8680 A most recent version of a notebook illustrating what seems to be a problem with using enumeration with explanation-related handlers is now in the ac-archive (PR #403 ), in the enumeration-explanation.ipynb notebook. If this gets resolved, the notebooks will need some updating, otherwise, I'm using sampling at least for now, and this shouldn't make much difference, as the number of possible combinations in the examples used in the notebooks is somewhat limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:explainable
Projects
None yet
Development

No branches or pull requests

2 participants