Attempt to modularize AC query code #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
added
enhancement
eb8680
commented
Aug 31, 2023
Comment on lines
94
to
99
| antecedent_handler = PartOfCause( | ||
| antecedents, bias=antecedent_bias, prefix="__antecedent_" | ||
| ) | ||
| treatment_handler = PartOfCause( | ||
| treatments, bias=treatment_bias, prefix="__treatment_" | ||
| ) |
There was a problem hiding this comment.
I'm a little unsure about this pair of PartOfCause handlers. It's not clear to me whether they're correctly encoding the relevant portion of the textbook definition.
eb8680
commented
Aug 31, 2023
Comment on lines
25
to
26
| if antecedents is None: | ||
| antecedents_ = list(indices_of(value, event_dim=event_dim).keys()) |
There was a problem hiding this comment.
Note the new default behavior of factual_preemption (previously preempt_with_factual) here. This is not exercised in the query code below or the pair of unit tests for PartOfCause initially included with this PR, and may be assuming too much about the free variables of value. I may remove or revert this before a version of factual_preemption lands in master.
This was referenced Sep 4, 2023
rfl-urbaniak
changed the base branch from
ru-actual-causality-notebooks
to
causality-staging
eb8680
added
status:WIP
|
Closing this now that PRs for all of the components except |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of modularizing and simplifying #236 #164
Targets #236, not
masterDepends on #238 #239
This PR is an attempt at simplifying the query code from @rfl-urbaniak's notebooks and turning it into library code. It attempts to be faithful to the notebooks, although after going through this exercise I have some new questions about the relationships between the textbook definitions and the latest query code in #236.
Only the changes in the new files
chirho/counterfactual/handlers/explanation.pyandtest/counterfactual/test_handlers_explanation.pyare new here. The others are merged from #238 and #239 and should land inmasterrelatively soon.