Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bkb charybdis tuned #50

Closed
wants to merge 2 commits into from

Conversation

ChrisSG
Copy link

@ChrisSG ChrisSG commented Jan 24, 2024

This adds the following features:

  • the trackball is dynamically enabled/disabled by moving it over a set threshold - this prevents accidential pointer movement especially when pressing keys that need reaching over the trackball
  • separate timing for tap-hold on the gui key to prevent accidential triggering
  • AltGr key on third row index finger hold to enable umlauts

CHARYBDIS_ENABLE_POINTER_ON_POINTER_LAYER_ONLY combined with CHARYBDIS_AUTO_POINTER_LAYER_TRIGGER_ENABLE makes the trackball enable/disable automatically. This prevents auto shiping.

Without CHARYBDIS_AUTO_POINTER_LAYER_TRIGGER_ENABLE it disables the trackball until the pointer layer is enabled manually.

Without both the trackball will constantly be enabled.

The actition threshold should feel smoth but might need some fine tuning depending on your DPI settings.

This adds the following bug fixes:

  • pointer stopping mid movement when using CHARYBDIS_AUTO_POINTER_LAYER_TRIGGER_ENABLE

ATTENTION: This introduces a suparate layer for auto pointer which might interfere with layer checks! This is needed for keeping the pointer enabled when auto enabling it and then additionally shifting to pointer layer manually.

…old for GUI key

Adds extra auto pointer layer to prevent auto disable when pointer layer key is pressed

Fixes auto pointer layer

Fine tunes the pointer timeout

Fixes QWERTY layout GUI tapping term
@0xcharly
Copy link
Collaborator

I appreciate the contribution, but all these changes are very opinionated, and objectively not a better default than what already exists, since this is ultimately based on user preference.

This also introduces a non-backward compatible change to the layers ID.

Also note that the auto-mouse behavior will ultimately be removed in favor of the core-QMK implementation (which didn't exist when we first wrote the Charybdis code).

Finally, it looks like it may be re-implementing something already provided by QMK? https://docs.qmk.fm/#/feature_pointing_device?id=pointing-device-auto-mouse

I'd suggest leveraging core-QMK if/when possible, and moving these change to a custom user-space instead.

@0xcharly 0xcharly closed this Jan 25, 2024
@ChrisSG
Copy link
Author

ChrisSG commented Jan 25, 2024

The main difference is that it completely disables the pointing device, not just the pointing layer. Not sure this can be achieved with the core implementation but will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants