Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to have CP be quiet #350

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Added option to have CP be quiet #350

merged 2 commits into from
Feb 23, 2021

Conversation

zilti
Copy link
Contributor

@zilti zilti commented Feb 18, 2021

Adding a -q option for CP, resolving #330 .

@cedwards
Copy link
Contributor

I like this patch (thank you).
My only feedback is to standardize with create and others in putting the option after the sub-command vs at the end.
ie; bastille cp -q TARGET source dest

@zilti
Copy link
Contributor Author

zilti commented Feb 19, 2021

Okay, this should be better.

@cedwards cedwards requested a review from JRGTH February 19, 2021 18:32
JRGTH
JRGTH approved these changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@JRGTH JRGTH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks option -q|--quite looks ok being after cp command now. ;)

@cedwards cedwards merged commit 3fe0380 into BastilleBSD:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRGTH JRGTH JRGTH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zilti @cedwards @michael-o @JRGTH