Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed to update_fstab() in clone.sh #446

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Fixed to update_fstab() in clone.sh #446

merged 2 commits into from
Dec 9, 2021

Conversation

frikilax
Copy link
Contributor

2 fixes to the update_fstab() function used in clone.sh:

  • remove duplicate match in grep expression for the FSTAB_RELEASE variable
  • ensure release is only returned once in FSTAB_RELEASE (avoid bugs in function when jail's name contains release's name)

@frikilax
CLONE.SH::FIXED:: remove duplicate match group in release grep during…
b0c5a61 
… fstab updating
@frikilax
CLONE.SH::FIXED:: ensure release grep in update_fstab only returns th…
3593846 
…e release name once


Situations could happen when release name could match several times (if jail name contains release name for example)
@cedwards cedwards merged commit da2f9bc into BastilleBSD:master Dec 9, 2021
@frikilax frikilax deleted the clone_fix branch December 13, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frikilax @cedwards