-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grid 3 #3
Conversation
Currently just a copy of plain text, will need implemented
@codetheweb Your code is brilliant 👌 Made adding this source so much easier |
Hey @codetheweb If you have time can you give this PR a review? I've added a new app to the appFactory. I called it I also added a warning to the data source screens to mention that this will pull every users history. It is unlikely that anyone will have more than one user that is active but thought we should still call it out. Any questions or comments to hesitate to ask :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks.
Last thing: several relatively large .sqlite
files have been added for testing (👍); would it be possible to re-export a smaller subset of data from those files?
On the sources list I wonder if it would be possible to put each grid user it finds as a separate source. Rather than currently it puts them all as one source. You’re going to have the odd situation where a device is shared - maybe just on loan - and you might want to remove all the users except one. If it’s a headache I wouldn’t worry. It’s going to be a rare situation. |
@codetheweb and @willwade Changes made:
@willwade - My thinking is we wait and see how much of problem that is? If we are constantly rejecting people from the collection due to not being able to submit because they are on a shared device then we can look into it but I don't think we should pre-empt the problem. Unless you are certain it is a common case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting on @willwade.
Looks good to me! To clarify - I think you are right. I don't think it should be a big problem in the real world. Services shouldn't really be giving users devices with other peoples data on there.. Go for it :) |
Still under development, just wanted to open a PR so you could follow my work.
Currently not everything is logged to the phrases file, single words spoken words are not logged by the looks of things. Despite this its still valuable to get all the spoken full phrases from Grid