quantisation fix + cue fix + git-clang-format #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t updated lenght info when updating outro start.
Be-ing
reviewed
Nov 10, 2019
| @@ -47,7 +47,6 @@ class Cue : public QObject { | |||
| void setEndPosition(double samplePosition); | |||
|
|
|||
| double getLength() const; | |||
| void setLength(double length); | |||
There was a problem hiding this comment.
Thank you for getting rid of this awkward function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here an improved #37 PR
It fixes the outro out past the end fix. During testing I experienced a second reason for this originated from the cue lenght store format.
I have also applied git-clang-format to the whole diff.
Unit test are working successful, and my manual test are also finished now.
Sorry for the hassle because of my previous commit.