Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/protocol 22 #28

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Feature/protocol 22 #28

merged 6 commits into from
Oct 23, 2024

Conversation

cuongph87
Copy link
Collaborator

@cuongph87 cuongph87 commented Oct 15, 2024

What's Changed

  • Added SubmitTransactionAsync function.
  • Updated outdated reference links.
  • Updated some Soroban unit tests.

Added support for Protocol 22

  • Latest XDR changes.
  • TxHash - hex-encoded transaction hash string - added to GetTransactionResponse and GetTransactionsResponse via TransactionInfo.
  • Added CreateContractV2HostFunction.

Breaking changes

  • Type of TransactionInfo.CreatedAt field (an indirect part of GetTransactionResponse and GetTransactionsResponse) changed from long to string.
  • Amount and NumAccounts fields removed from AssetResponse.
  • Cost field removed from SimulateTransactionResponse.
  • PagingToken removed from GetEventsResponse.EventInfo and replaced with GetEventsResponse.Cursor.
  • An extra parameter arguments added to CreateContractOperation.FromAsset static factory method to support CreateContractV2HostFunction.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jopmiddelkamp
jopmiddelkamp previously approved these changes Oct 23, 2024
@cuongph87 cuongph87 merged commit 36c56e2 into master Oct 23, 2024
1 check passed
@cuongph87 cuongph87 deleted the feature/protocol-22 branch October 23, 2024 05:07
@cuongph87 cuongph87 restored the feature/protocol-22 branch October 23, 2024 05:18
@cuongph87 cuongph87 deleted the feature/protocol-22 branch October 23, 2024 06:36
@cuongph87 cuongph87 restored the feature/protocol-22 branch October 23, 2024 06:50
@cuongph87 cuongph87 deleted the feature/protocol-22 branch October 25, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants