Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3376 more numpy imports #3381

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Closes #3376 more numpy imports #3381

merged 1 commit into from
Jul 9, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Jul 2, 2024 •
edited
Loading

Closes #3376 more numpy imports

Adds:

  • DataSource,
  • False_,
  • ScalarType,
  • True_,
  • base_repr,
  • binary_repr,
  • cfloat,
  • clongfloat,
  • compat,
  • flexible,
  • float_,
  • format_float_positional,
  • format_float_scientific,
  • inexact,
  • issctype,
  • longfloat,
  • maximum_sctype,
  • promote_types,
  • sctypeDict,
  • sctypes,
  • uintp,
  • unsignedinteger,
  • RankWarning,
  • add_docstring,
  • add_newdoc,
  • deprecate,
  • deprecate_with_doc,
  • disp,
  • issubclass_,
  • issubdtype,
  • polynomial,
  • typename,
  • format_parser,
  • polynomial

Removes:

  • newaxis (not really a scalar function and shouldn't be imported like this)

@ajpotts
Copy link
Contributor Author

ajpotts commented Jul 2, 2024

The script doesn't really need to be included. It's just to show how I identified the scalars. I could delete it if that is better.

@ajpotts ajpotts marked this pull request as ready for review July 2, 2024 16:09
jaketrookman
jaketrookman approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

stress-tess
stress-tess approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@stress-tess stress-tess added this pull request to the merge queue Jul 9, 2024
Merged via the queue into Bears-R-Us:master with commit 343cb5c Jul 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

more numpy imports
3 participants
@ajpotts @stress-tess @jaketrookman