Updates PROTOs pdarray_creation_test #3393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates PROTO-tests/tests/pdarray_creation_test.py to ensure that it covers all of the same tests that the non-PROTOs version did.
Several tests that are done in one function in tests are done in multiple ones in PROTO-tests (e.g. test_randint vs test_randint_array_dtype, test_randint_num_dtype, test_randint_misc). This makes for a challenging crosswalk, but I think that everything has been updated.
I made the following changes to ones_like, zeros_like, and full_like:
In addition to the note above about shape, several other functions will have to be updated when we implement n-d arrays. For example, it currently asserts that n-d arrays have ArrayView type.