Fix sparseMatToPdarray test failures for distributed arrays #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trols for whether domains are distributed. Use same makeSparseArray routine in SparseSymArray and randSparseMatrix helper proc Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
…ad of 1 locale at a time Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
bmcdonald3
approved these changes
Oct 7, 2024
…esses to CSR/CSC data structures Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
ShreyasKhandekar
approved these changes
Oct 7, 2024
…ow/column. Use 'rows/colsAndVals' iterators to avoid use of 'contains' query when populating 1D arrays Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
stress-tess
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of bugs with the distributed implementation of sparseMatToPdarray.
Also fixes a few other bugs/issues with the sparse matrix code:
ChplConfig.CHPL_COMMis now used to determine whether sparse matrices are distributed. Matrices created byrandSparseMatrixwere always distributed before.SparseSymEntryclass now stores a distributed sparse array when the server is configured for multi-locale. It was always storing a non-distributed array before.fillSparseMatrixnow populates matrices in either a row-major (for CSR) or column-major (for CSC) order. For distributed arrays, it was populating values one locale at a time, causing them to appear out of order overall.sparseMatToPdarraywas doing the inverse operation, instead of returning values in a global row-major or column-major order