Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module-level documentation and 'Quick start' section. #95

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

ismael-lajaaiti
Copy link
Collaborator

@ismael-lajaaiti ismael-lajaaiti commented Jan 16, 2023

Changes

@ismael-lajaaiti
Copy link
Collaborator Author

ismael-lajaaiti commented Feb 15, 2023

Could this PR be merged (after rebasing it), as the last point of the TODO belong now to #107 (@iago-lito) ?

@ismael-lajaaiti ismael-lajaaiti changed the title Improve documentation Module-level documentation and 'Quick start' section. Feb 15, 2023
@ismael-lajaaiti ismael-lajaaiti added the documentation Improvements or additions to documentation label Feb 15, 2023
@iago-lito
Copy link
Collaborator

Wop! I had completely forgotten about these two commits. Sorry for that @ismael-lajaaiti, I'm having a look at them rn.

@iago-lito
Copy link
Collaborator

Well, yes. I see no reason not to rebase this at least. Can you rebase and then maybe ask @Thomalpas for review?

@iago-lito iago-lito self-requested a review February 15, 2023 14:44
@ismael-lajaaiti
Copy link
Collaborator Author

I have rebased the branch on top of dev. (First time handling conflict with neovim, hope everything went well 🤞)

docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
docs/src/man/quickstart.md Outdated Show resolved Hide resolved
src/BEFWM2.jl Outdated Show resolved Hide resolved
src/BEFWM2.jl Outdated Show resolved Hide resolved
src/BEFWM2.jl Outdated Show resolved Hide resolved
src/BEFWM2.jl Outdated Show resolved Hide resolved
@ismael-lajaaiti
Copy link
Collaborator Author

Thanks for your review @Thomalpas, here are the changes requested. Let me know if now everything is good for you.
If so, @iago-lito I think that this branch will be ready to be merged.

@Thomalpas
Copy link
Collaborator

Am happy thank you @ismael-lajaaiti

Copy link
Collaborator

@iago-lito iago-lito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ismael-lajaaiti! This looks good to me, except that the tests are broken because you labeled ] add Package as julia code in the docs although it's not. Once this is fixed, you need to autoformat your files and we'll be good to go :)
Thank you @Thomalpas for having checked the English language here <3


## References
```julia
] add EcologicalNetworkDynamics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wop! This is not exactly Julia code, it's another language corresponding to the "package mode" of Julia. This breaks autoformatting checks, because JuliaFormatter parses all ```julia chunks, considering they contain Julia code.

Maybe you can fix that by using ```julia-pkg instead?

Copy link
Collaborator Author

@ismael-lajaaiti ismael-lajaaiti Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go for the equivalent in the Julia language i.e.

using Pkg
Pkg.add("EcologicalNetworksDynamics")

If it's good for you.


## How can I contribute?

The easiest way to contribute is to [open an issue](https://github.com/BecksLab/EcologicalNetworksDynamics.jl/issues)
The easiest way to contribute is to [open an issue](https://pkg-url/issues)
Copy link
Collaborator

@iago-lito iago-lito Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know the package url now that #100 happened :) You can replace all these mock urls with https://github.com/BecksLab/EcologicalNetworksDynamics.jl/ now!

@@ -126,7 +126,7 @@ You can pass any of those models, with the required arguments, to generate food
using EcologicalNetworks
S = 20 # species richness
C = 0.2 # connectance
foodweb = FoodWeb(nichemodel, S; C = C)
foodweb = FoodWeb(nichemodel, S; C, tol = 0.01)
Copy link
Collaborator

@iago-lito iago-lito Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay, leave a note somewhere on your desk to come back and update this once #115 is fixed ;)


```@example quickstart
using EcologicalNetworksDynamics, Plots
fw = FoodWeb([1 => 2, 2 => 3]) # 1 eats 2, and 2 eats 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@iago-lito iago-lito force-pushed the improve_doc branch 2 times, most recently from ee5a6f1 to b583965 Compare February 24, 2023 13:21
Copy link
Collaborator

@iago-lito iago-lito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, only minor comments below, that I can just fix myself while squashing and rebasing this. Good job :)


During your journey learning EcologicalNetworksDynamics you might encounter issues.
If so the best is to open an issue on the
[GitHub page of EcologicalNetworksDynamics](https://pkg-url/issues).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url has not been updated X)

!!! note "Todo"

Update url address if needed when the package is released.
The contribution guidelines are detailed [here](https://pkg-url/contributing.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url neither X)

@iago-lito iago-lito merged commit 66df8b1 into BecksLab:dev Feb 24, 2023
@iago-lito iago-lito removed a link to an issue Feb 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write module-level documentation Welcome and quick start page
3 participants