Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize CHANGES #173

Merged
merged 8 commits into from
Aug 1, 2021
Merged

finalize CHANGES #173

merged 8 commits into from
Aug 1, 2021

Conversation

orbeckst
Copy link
Member

  • release 0.7.0 date in CHANGES
  • update setup.py (twine check indicated missing long_description_content_type)
  • for release 0.7.0 #105

- release 0.7.0 date in CHANGES
- update setup.py (twine check indicated missing long_description_content_type)
@orbeckst orbeckst added this to the 0.7 milestone Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #173 (77bf4ad) into develop (4d2498b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #173   +/-   ##
========================================
  Coverage    68.98%   68.98%           
========================================
  Files            9        9           
  Lines         1396     1396           
  Branches       190      190           
========================================
  Hits           963      963           
  Misses         363      363           
  Partials        70       70           
Impacted Files Coverage Δ
mdpow/fep.py 59.37% <ø> (ø)
mdpow/filelock.py 90.00% <100.00%> (ø)
mdpow/forcefields.py 85.54% <100.00%> (ø)
mdpow/restart.py 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2498b...77bf4ad. Read the comment docs.

@orbeckst
Copy link
Member Author

Failed with

Fatal error:
There are 1 perturbed non-bonded pair interactions beyond the pair-list cutoff
of 1.039 nm, which is not supported. This can happen because the system is
unstable or because intra-molecular interactions at long distances are
excluded. If the latter is the case, you can try to increase nstlist or rlist
to avoid this.The error is likely triggered by the use of couple-intramol=no
and the maximal distance in the decoupled molecule exceeding rlist.

so we can run into the GROMACS exclusions bug in our tests. We need to increase rlist to guarantee tests to pass.

@orbeckst orbeckst mentioned this pull request Jul 30, 2021
5 tasks
@orbeckst
Copy link
Member Author

orbeckst commented Jul 31, 2021

Given that the tests pass most of the time I am not going to change them right now, if needed rerun a failing test. Will raise an issue.

CHANGES Outdated Show resolved Hide resolved
@@ -137,12 +136,12 @@

# The name of an image file (relative to this directory) to place at the top
# of the sidebar.
#html_logo = None
html_logo = "_static/mdpow-logo.png"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the docs under status : we hav a logo now

Copy link
Contributor

@ALescoulie ALescoulie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the updates to the docs will defiantly be a plus. With the scripts fixed it should make the terminal workflow compatible with modern python.

Copy link
Collaborator

@iorga iorga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the hard work !

@orbeckst
Copy link
Member Author

orbeckst commented Aug 1, 2021

Thank you all for having a look, much appreciated.

@orbeckst orbeckst merged commit 43485dd into develop Aug 1, 2021
@orbeckst orbeckst deleted the prep-release-070 branch August 1, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants