This repository has been archived by the owner on Dec 18, 2022. It is now read-only.
Namespaced twig syntax for views #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this? |
garak
reviewed
Apr 30, 2019
| @@ -3,8 +3,7 @@ | |||
| namespace Beelab\UserBundle\Controller; | |||
|
|
|||
| use Psr\Log\LoggerInterface; | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method; | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; | |||
| use Symfony\Component\Routing\Annotation\Route; | |||
There was a problem hiding this comment.
This is in the wrong place and it does not respect sorting. Please move it after "use Symfony\Component\HttpFoundation\Request"
| @@ -5,8 +5,7 @@ | |||
| use Beelab\UserBundle\Event\FormEvent; | |||
| use Beelab\UserBundle\Event\UserEvent; | |||
| use Beelab\UserBundle\Manager\UserManagerInterface; | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method; | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; | |||
| use Symfony\Component\Routing\Annotation\Route; | |||
| @@ -2,12 +2,10 @@ | |||
|
|
|||
| namespace Beelab\UserBundle\User; | |||
|
|
|||
| use Symfony\Component\Security\Core\User\AdvancedUserInterface; | |||
There was a problem hiding this comment.
Hi! sorry about the delay.
It's been a while, but if i recall correclty it was a deprecated call.
Feel free to refuse it if you find this contribution useless.
regards.
There was a problem hiding this comment.
Yes, AdvancedUserInterface was deprecated.
Anyway, this change should be in a different PR
|
Bump |
|
This is here for a long time, a bit too much IMHO. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as previously done for BeelabUserPasswordBundle:
Templates can't be overriden without the namespaced twig syntax anymore.
ie : change 'BeelabUserBundle:User:index.html.twig' to '@BeelabUser/User/index.html.twig' must solve the issue.
I also did fix deprecated dependencies to
@Methodand@Routeand a deprecated call toAdvancedUserInterface.