Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes pickaxe mining less miserable #11714

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RDS88-beeman
Copy link
Contributor

@RDS88-beeman RDS88-beeman commented Oct 16, 2024

About The Pull Request

This makes all pickaxes (not drills, not PKAs, not crushers, not resonators, just pickaxes) mine faster, at the cost of requiring stamina to use.
Standard pickaxes deal five damage per picking action, clamped to 75, while mining as fast as silver pickaxes.
Silver pickaxes are the same, but deal three damage per action.
Diamond pickaxes also deal three damage per action, but are "fast as fuck".
Ignore the glitter, that's being atomised.

Why It's Good For The Game

Ruko told me to and I trust his game design judgement. I also play ashwalker, and pickaxe mining as an ashwalker is miserable. This helps that take less time, while also making it not a unilateral buff.

Testing Photographs and Procedure

Screenshots&Videos

I personally have gotten away with not providing testing evidence for a lot of PR's by going "just trust me."
However, I still don't have any way of recording testing video or taking images, so you are just going to have to trust me on this one. I solemnly swear I did in fact take this into a private server and make sure it all worked.

Changelog

🆑
balance: Pickaxes are faster now, you can put your back into it! Granted, putting your back into it tends to tire you out, so watch out for that.
/:cl:

@MarkusLarsson421
Copy link
Contributor

Get some testing evidence. smh

@Rukofamicom
Copy link
Contributor

This does make normal pickaxes (0.5) technically faster than normal drills (0.6), but drills don't have the stamina cost.

@Rukofamicom
Copy link
Contributor

Rukofamicom commented Oct 16, 2024

dreamseeker_guLi7KO0jE

dreamseeker_DqPCZs4ecG

here's your testing evidence.
You talked about the testing process with me some too, so I'm willing to conjure this one up

@Rukofamicom
Copy link
Contributor

I do really recommend sharex for testing evidence. It's what I just used to produce those.

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, having tested it the stamina cost does feel a bit steep for what I was thinking.

I do see my initial comment about the drill was incorrect now that I'm looking at the code as well.

code/modules/mining/equipment/mining_tools.dm Outdated Show resolved Hide resolved
code/modules/mining/equipment/mining_tools.dm Outdated Show resolved Hide resolved
RDS88-beeman and others added 2 commits October 21, 2024 16:56
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
Co-authored-by: Rukofamicom <oozelingcomplaints@gmail.com>
@RDS88-beeman
Copy link
Contributor Author

dreamseeker_KUCAQZZ0OA
this is borg proof, they still work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants