515 Fixes and Auxmos 2.5.2 #2703
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumps rust_g to the latest version * Partial port of tgstation/tgstation#56183 Co-authored-by: AnturK <AnturK@users.noreply.github.com> * Re-formats fname params --------- Co-authored-by: AnturK <AnturK@users.noreply.github.com>
* Bump to rustg v3.1.0 * Implement rustg_icon_states * Update dependencies.sh * Update rust version too * Revert "Implement rustg_icon_states" This reverts commit 42db8ec27adc74e3b9742da35aa32d0bc452e4da. * Bump to 3.1.1
* GAGS Rustg * Bump rust-g to 3.1.2 * Move to tmp * Copy json configs into tests * Fix tests * Begone tabs * Optimize greyscale_layer init
* Update dependencies.sh * Add files via upload
covertcorvid
commented
Aug 10, 2024
Comment on lines
+184
to
+186
| #define ATMOS_TANK_BZ "bz=100000;TEMP=293.15" | ||
| #define ATMOS_TANK_PLUOXIUM "pluox=100000;TEMP=293.15" | ||
| #define ATMOS_TANK_TRITIUM "tritium=100000;TEMP=293.15" |
There was a problem hiding this comment.
Did I actually use these anywhere?
code/__DEFINES/rust_g.dm
Outdated
| @@ -169,6 +200,80 @@ | |||
| #define rustg_http_request_async(method, url, body, headers, options) RUSTG_CALL(RUST_G, "http_request_async")(method, url, body, headers, options) | |||
| #define rustg_http_check_request(req_id) RUSTG_CALL(RUST_G, "http_check_request")(req_id) | |||
|
|
|||
| /// Generates a spritesheet at: [file_path][spritesheet_name]_[size_id].png | |||
There was a problem hiding this comment.
Not sure how much I needed any of this
| @@ -549,7 +549,7 @@ | |||
| if(!istype(T)) | |||
| return | |||
| var/datum/gas_mixture/environment = T.return_air() | |||
| if(!istype(environment)) | |||
| if(!environment) | |||
| @@ -2,7 +2,6 @@ | |||
| //Datum gets created in master.dm because for whatever reason global code in there gets runs first | |||
| //In case we ever figure out how to manipulate global init order please move the datum creation into this file | |||
| /datum/debugger | |||
There was a problem hiding this comment.
to be completely honest I do not know what the debugger does and had to remove it from world.dm to stop everything from hanging on startup
…e tests" This reverts commit d44bba3.
covertcorvid
commented
Aug 11, 2024
| @@ -9,7 +9,7 @@ | |||
| config/starmap/starmap.json | |||
|
|
|||
| # Ignore compiled linux libs in the root folder, e.g. librust_g.so | |||
| /*.so | |||
| #/*.so | |||
There was a problem hiding this comment.
this wasn't actually the problem I was having but I'm wondering if I should leave the so file in anyways to be nice to that one guy who's trying to develop on linux
covertcorvid
commented
Aug 11, 2024
| @@ -7,8 +7,13 @@ | |||
| #define WRITE_FILE(file, text) DIRECT_OUTPUT(file, text) | |||
| #define READ_FILE(file, text) DIRECT_INPUT(file, text) | |||
| //This is an external call, "true" and "false" are how rust parses out booleans | |||
| #ifdef EXTOOLS_LOGGING | |||
There was a problem hiding this comment.
should this be auxtools logging?
covertcorvid
commented
Aug 11, 2024
| auxmos_path = "./libauxmos.so" | ||
| else if (fexists("./auxtools/libauxmos.so")) | ||
| auxmos_path = "./auxtools/libauxmos.so" | ||
| else if (fexists("[world.GetConfig("env", "HOME")]/.byond/bin/libauxmos.so")) |
There was a problem hiding this comment.
do we still need to look in home?
covertcorvid
commented
Aug 11, 2024
| @@ -4,11 +4,10 @@ SUBSYSTEM_DEF(callbacks) | |||
| wait = 1 | |||
| priority = FIRE_PRIORITY_CALLBACKS | |||
|
|
|||
| /proc/process_atmos_callbacks() | |||
There was a problem hiding this comment.
global proc moved to bindings.dm, this is fine
covertcorvid
commented
Aug 11, 2024
covertcorvid
commented
Aug 11, 2024
| @@ -100,22 +100,22 @@ | |||
| if(node2) | |||
| node2.disconnect(src) | |||
| nodes[2] = null | |||
| nullifyPipenet(parents[2]) | |||
There was a problem hiding this comment.
renames caused a lot of purely aesthetic changes, decide whether to keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This ups some version numbers, fixes a NAMEOF call, and updates atmos to use an actual library API instead of weird DLL hacks.
This still needs experimental testing but I'm partly putting this up just to be able to do my own code review
References yogstation13/Yogstation#13479 and Citadel-Station-13/Citadel-Station-13#16061
Why It's Good For The Game
I love the idea of not having weird DLL hacks, also the firelocks seem to work better.
Also also people will actually be able to compile and run the code in 515 now.
Testing Photographs and Procedure
Atmos tests:
Changelog
🆑 juypterkat, covertcorvid
fix: Firelocks respond to depressurization better
refactor: A lot of the atmos subsystem got reorganized at minimum
add: auxmos might be handling fusion now if I understood this correctly
server: Updated auxmos to 2.5.2 and my fork - PreCompile.sh changed
server: Also updated rustg
/:cl: