-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-modal-shell): update modal header #315
Conversation
-Change header title to h2; move to be inline with close button -Ensure there is no underline (that may appear as a result of ds utility classes)
<div class="tableClass"> | ||
<div class="cellClass"> | ||
<div class="ds-c-dialog {{modalClass}}" role="document"> | ||
<div class="modal-header-wrapper ds-u-display--flex ds-u-margin-bottom--2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual changes are here...(the rest is mostly just reformatting...sorry, it's a habit!)
Wrap the title and close button in .modal-header-wrapper
Change defaultHeader template to use h2 instead of h1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
I, for one, welcome the formatting changes :) |
### [4.4.2](v4.4.1...v4.4.2) (2022-04-06) ### Bug Fixes * **app-modal-shell:** update modal header ([#315](#315)) ([b3403bb](b3403bb))
🎉 This PR is included in version 4.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
To be inline with the HCD Figma designs, the following changes have been made: