fix(app-modal-shell): update modal header #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Change header title to h2; move to be inline with close button -Ensure there is no underline (that may appear as a result of ds utility classes)
dianadean
commented
Apr 5, 2022
| <div class="tableClass"> | ||
| <div class="cellClass"> | ||
| <div class="ds-c-dialog {{modalClass}}" role="document"> | ||
| <div class="modal-header-wrapper ds-u-display--flex ds-u-margin-bottom--2"> |
There was a problem hiding this comment.
Actual changes are here...(the rest is mostly just reformatting...sorry, it's a habit!)
Wrap the title and close button in .modal-header-wrapper
Change defaultHeader template to use h2 instead of h1
mcelestini
reviewed
Apr 5, 2022
|
I, for one, welcome the formatting changes :) |
hitjim
approved these changes
Apr 5, 2022
cshamrick
pushed a commit
that referenced
this pull request
Apr 6, 2022
### [4.4.2](v4.4.1...v4.4.2) (2022-04-06) ### Bug Fixes * **app-modal-shell:** update modal header ([#315](#315)) ([b3403bb](b3403bb))
|
🎉 This PR is included in version 4.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be inline with the HCD Figma designs, the following changes have been made: