Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable/disable display of notifications #33

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

adamblackburn
Copy link
Contributor

Add checkbox to enable/disable display of notifications. The sound that occurred with the notifications on Win10 was quite distracting.

Add checkbox to enable/disable display of notifications
@Belphemur
Copy link
Owner

Hello Adam,

I'm travelling for the moment and I just have my smart phone. The code and use case seemed good to me.

I'll test it and merge it asap.

-----Message d'origine-----
De : "Adam Blackburn" notifications@github.com
Envoyé : ‎21-‎11-‎15 09:57
À : "Belphemur/SoundSwitch" SoundSwitch@noreply.github.com
Objet : [SoundSwitch] Allow enable/disable display of notifications (#33)

Add checkbox to enable/disable display of notifications. The sound that occurred with the notifications on Win10 was quite distracting.

You can view, comment on, or merge this pull request online at:
#33
Commit Summary
Allow enable/disable display of notifications
File Changes
M .gitignore (3)
M SoundSwitch/Framework/Configuration/ISoundSwitchConfiguration.cs (1)
M SoundSwitch/Framework/Configuration/SoundSwitchConfiguration.cs (3)
M SoundSwitch/Model/AppModel.cs (10)
M SoundSwitch/Model/IAppModel.cs (6)
M SoundSwitch/SoundSwitch.csproj (3)
M SoundSwitch/UI/Forms/Settings.Designer.cs (37)
M SoundSwitch/UI/Forms/Settings.cs (8)
A SoundSwitch/UI/Forms/Settings.resx (120)
M SoundSwitch/Util/TrayIcon.cs (12)
Patch Links:
https://github.com/Belphemur/SoundSwitch/pull/33.patch
https://github.com/Belphemur/SoundSwitch/pull/33.diff

Reply to this email directly or view it on GitHub.

Belphemur added a commit that referenced this pull request Dec 1, 2015
Allow enable/disable display of notifications
@Belphemur Belphemur merged commit 99ce54b into Belphemur:master Dec 1, 2015
@Belphemur
Copy link
Owner

@all-contributors please add @adamblackburn for code

@allcontributors
Copy link
Contributor

@Belphemur

I've put up a pull request to add @adamblackburn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants