1.21 Support

[GitNuck]

Hi I was wondering if FastCraft is going to be updated to support 1.21 in the near future?

[BenWoodworth]

Hey! I haven't been following Bukkit/Spigot updates too closely, but looking through the recent releases I didn't see anything that might break compatibility. Is something breaking when you try FastCraft with 1.21?

I do get one error when building FastCraft with 1.21, so that could be an issue. A couple weeks ago one class was changed into an interface, so now FastCraft might fail there. Besides that, though, let me know. I can probably take a closer look at this later in the week

Compilation Issue

Compilation error:

Breaking Change in Spigot

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/2b4b6d14241d3d96eb6b7d1888176146dc5895d4#src/main/java/org/bukkit/inventory/InventoryView.java

[BenWoodworth]

I'm curious if that compilation error is actually an issue, because in the changelog, it looks like there might be come compatibility to make it work. (And if FastCraft's UI opens up, then that might mean 1.21 is already supported)

Spigot Changelog

[GitNuck]

Thank you for the reply, FastCraft's UI opens but there is nothing shown in the crafting grid, and the console gets spammed with an error.

[GitNuck]

[22:52:48 WARN]: [FastCraft] Task #2097 for FastCraft v3.2.12 generated an exception
java.lang.IncompatibleClassChangeError: class net.benwoodworth.fastcraft.bukkit.recipe.CraftingInventoryViewFactory_1_14$CustomInventoryView has interface org.bukkit.inventory.InventoryView as super class
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.bukkit.recipe.CraftingInventoryViewFactory_1_14.create(CraftingInventoryViewFactory_1_14.kt:20) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.bukkit.recipe.FcCraftingRecipe_Bukkit_1_7.prepare-bH9MJnY(FcCraftingRecipe_Bukkit_1_7.kt:98) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.crafting.model.CraftableRecipeFinder$prepareCraftableRecipes$1.invokeSuspend(CraftableRecipeFinder.kt:127) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.lib.kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.lib.kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:140) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.lib.kotlin.sequences.FlatteningSequence$iterator$1.ensureItemIterator(Sequences.kt:316) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.lib.kotlin.sequences.FlatteningSequence$iterator$1.hasNext(Sequences.kt:303) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.crafting.model.CraftableRecipeFinder$loadRecipes$1$2.invoke(CraftableRecipeFinder.kt:68) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.crafting.model.CraftableRecipeFinder$loadRecipes$1$2.invoke(CraftableRecipeFinder.kt:64) ~[FastCraft-3.2.12.jar:?]
at FastCraft-3.2.12.jar/net.benwoodworth.fastcraft.bukkit.server.FcTask_Bukkit_1_7.init$lambda-0(FcTask_Bukkit_1_7.kt:20) ~[FastCraft-3.2.12.jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:482) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1689) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:507) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1573) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1275) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:332) ~[purpur-1.21.jar:1.21-2252-d5c06b4]
at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]

[BenWoodworth]

Alright, nice! Thanks for helping get the error, it's good to confirm that the InventoryView is what's causing issues.

I was looking around and found this:

... Spigot will remap your InventoryView usage as necessary, and if that isn't working, that is a bug and should be reported.

And it points to the same commit that I saw in the changelog. I didn't actually look at the change before, but the "class-to-interface compatibility" change that I screenshotted before does actually address InventoryView specifically, on line 71.

---

I just built the latest Spigot 1.21-R0.1-SNAPSHOT to try, and it does seem to be working for me:

Spigot 1.21-4260

I also tried the latest Paper (which Purpur is based on), and that's also working for me:

Paper 1.21-47

And finally, most interestingly, I tried on the latest Purpur, and that is failing for me with the same error as you (despite seeming to be up-to-date enough to have that class-to-interface compatibility)

Purpur 1.21-2256 (FAILING)

[BenWoodworth]

The fact that it's working for Paper and not Purpur makes me think it's something that the Purpur folks should look into, since other plugins that use the InventoryView will be unnecessarily broken. Are you alright raising an issue with them, maybe pointing to this discussion if it helps.

Going by this, I'm hesitant to address this with a FastCraft update, because it looks like the same kind of issue will pop up more later down the line, and pushing updates for a fork of a fork (spigot -> paper -> purpur) would be a little bit of a headache:

... Their end goal is to completely replace all abstract classes with interfaces as stated on the spigot discord server.

So with this experience, remember that it will be happening again, they have quite a few abstract classes to replace.

If it's still an issue after spigot/paper/purpur 1.21 are no longer experimental, I might take a second look at this. I would be curious what the Purpur devs think of this, though.

[GitNuck]

Thank you so much for your time and effort in troubleshooting and finding the bug. There is a new Purpur build out I'll try and see if it is solved, might get lucky. I'll check back once 1.21 is no longer bleeding edge.

[GitNuck]

Can confirm the latest Purpur pushed a patch and it is solved! Thanks again :)

[tylerking]

I'm late to this conversation but I came looking for updates to this issue and noticed this comment. I'm on the latest version of Purpur and it does not work for me. If you dont mind could you tell me exactly what version worked for you? I'm on Purpur 1.21-2280-930003b (MC: 1.21)*. It loads the plugin but the crafting grid is empty and unlike you there is absolutely no errors in the console during startup or in game. Thanks in advance.

[GitNuck]

I am running the same version of Purpur as you and it works fine on my end. Try deleting the folder and jar file and re-install. Other than that then another plugin may be interfering, and you'll have to play the plugin removal game.

[tylerking]

Interesting...well thanks for getting me back to me so fast. I guess I'll be playing the plugin removal game then. Wish me luck.

[GitNuck]