Adding Android Home support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EdbertChan mind taking a look at the failing tests? |
Bencodes
reviewed
Apr 11, 2024
rules/attrs.bzl
Outdated
| @@ -34,6 +34,10 @@ ATTRS = dict( | |||
| allow_single_file = True, | |||
| doc = "Android manifest to run Android Lint against.", | |||
| ), | |||
| android_home = attr.label( | |||
There was a problem hiding this comment.
This should really live at the toolchain level instead of needing to be passed to every single target.
Bencodes
reviewed
Apr 11, 2024
rules/impl.bzl
Outdated
| @@ -116,6 +116,10 @@ def _run_android_lint( | |||
| args.add("--output", output) | |||
| outputs.append(output) | |||
|
|
|||
| label = ctx.attr.android_home.label | |||
There was a problem hiding this comment.
This will throw a null pointer if android_home isn't set.
EdbertChan
force-pushed
the
android_home_support
branch
from
985d3bd to
8888f1b
Compare
EdbertChan
force-pushed
the
android_home_support
branch
from
9fdcadc to
69332d6
Compare
Bencodes
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly inject android_home into lint and reconstructs the absolute path without resorting to using the ANDROID_HOME environment variable outside of Bazel.
This is opposed to [Grab's approach.](https://github.com/grab/grab-bazel-common/blob/02735d57ab96392d9b590398218a6be3e1f[…]3813f/tools/lint/src/main/java/com/grab/lint/LintBaseCommand.kt](https://github.com/grab/grab-bazel-common/blob/02735d57ab96392d9b590398218a6be3e1f3813f/tools/lint/src/main/java/com/grab/lint/LintBaseCommand.kt#L213C28-L213C40) that constructs the field from environment variable.
How to Use:
This way, we keep the sdk in parity with whatever we have specified in WORKSPACE.