Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set modify_params before merging consecutive u/a messages to avoid anthropic fail #2663

Closed
wants to merge 1 commit into from

Conversation

morgante
Copy link

This logic is faulty (see #2662).

I don't want it to run at all. It's unreliable, and I didn't ask LiteLLM to rewrite my messages.

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 8:58pm

@krrishdholakia krrishdholakia changed the title fix: skip faulty merge logic if we didn't ask for modifications fix: set modify_params before merging consecutive u/a messages to avoid anthropic fail Mar 23, 2024
@krrishdholakia
Copy link
Contributor

@morgante the logic seems to work based on our conversation in #2662

Attaching a screenshot of this working as well.

Screenshot 2024-03-23 at 2 08 54 PM

Continuing the conversation on #2662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants