Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Competition Lobby Frontent page generation #1441

Closed
jonsnowpt opened this issue Jul 11, 2023 · 6 comments
Closed

Competition Lobby Frontent page generation #1441

jonsnowpt opened this issue Jul 11, 2023 · 6 comments
Assignees
Labels
📣 [A] high priority Something that needs attention and accelerated resolving 🎨 Frontend

Comments

@jonsnowpt
Copy link
Contributor

jonsnowpt commented Jul 11, 2023

For the competitions, we will have the "lobby" where the users will be able to check all available competitions besides the page per each competition.

The lobby is generated based on the competitions_home_translations

Image


📱 TARGET PLATFORMS

The competition Home page will be available on all versions, desktop, tablet, and mobile.


🎬 INITIAL STATE

Data used for the lobby frontend page creation (endpoint: competitions_home_translations):

Breadcrumbs:

url = competitions_home_translations/data {title}

Page URL

url = competitions_home_translations/data {title}

Example: https://scores.betarena.com/competitions

SEO

The endpoint to get the SEO data: ** competitions_seo_homepage**. Depending on the language, the following data should be loaded:

main_data
opengraph
twitter_card

Make use of the hreflang for all available languages.

    <link rel="alternate" hrefLang="it" href="https://scores.betarena.com/it/competizioni">
    <link rel="alternate" hrefLang="es" href="https://scores.betarena.com/es/competiciones">
    <link rel="alternate" hrefLang="fr" href="https://scores.betarena.com/fr/competitions">
    <link rel="alternate" hrefLang="pt" href="https://scores.betarena.com/pt/competicoes">
    <link rel="alternate" hrefLang="pt-BR" href="https://scores.betarena.com/br/competicoes">
    <link rel="alternate" hrefLang="ro" href="https://scores.betarena.com/ro/competiții">
    <link rel="alternate" hrefLang="se" href="https://scores.betarena.com/se/tavlingar">
    <link rel="alternate" hrefLang="x-default" href="https://scores.betarena.com/competitions">
    <link rel="canonical" href="https://scores.betarena.com/competitions">

Load the correct SEO information:

competitions_seo_homepage

SEO ENDPOINT: competitions_seo_homepage

Example content:

EN 

main_data

{"title":"Betarena Daily Fantasy Sports for Cash","noindex":"false","keywords":"Competitions","nofollow":"false","canonical":"https://scores.betarena.com/competitions","description":"Engage in thrilling new sports competitions on Betarena. Showcase your skills, win prizes, and stay updated with the latest tournament formats. Join now!"}

opengraph

{"url":"https://scores.betarena.com/competitions","type":"website","title":"Betarena Daily Fantasy Sports for Cash","images":[{"alt":"Competitions","url":"https://www.betarena.com/wp-content/uploads/2021/12/betarena_scores.jpeg","width":850,"height":650}],"locale":"en_GB","description":"Engage in thrilling new sports competitions on Betarena. Showcase your skills, win prizes, and stay updated with the latest tournament formats. Join now!"}

twitter_card

{"site":"@betarenasocial","image":"https://www.betarena.com/wp-content/uploads/2021/12/betarena_scores.jpeg","title":"Betarena Daily Fantasy Sports for Cash","imageAlt":"Competitions","description":"Engage in thrilling new sports competitions on Betarena. Showcase your skills, win prizes, and stay updated with the latest tournament formats. Join now!"}


Versions:

This section will be available on Light and Dark Theme.


Data Endpoints:

Hasura endpoint Prod:

competitions_seo_homepage
competitions_home_translations

⚡️ CACHE

Fallback approach.


Hreflang Support:

Add alternate lang pages for search engine optimization.


Resources

Figma Design:

https://www.figma.com/file/2hrUqV3U6a82pJYqGsAghH/Betarena?type=design&node-id=3646%3A26969&mode=design&t=T6PMWA2fXUQ6V4bP-1

@jonsnowpt jonsnowpt self-assigned this Jul 11, 2023
@jonsnowpt jonsnowpt converted this from a draft issue Jul 11, 2023
@jonsnowpt jonsnowpt added 📣 [A] high priority Something that needs attention and accelerated resolving 🎨 Frontend labels Jul 11, 2023
@jonsnowpt jonsnowpt moved this to Backlog in Betarena Scores Jul 11, 2023
@jonsnowpt jonsnowpt moved this from Backlog to Icebox in Betarena Scores Jul 31, 2023
@jonsnowpt jonsnowpt moved this from Icebox to Todo in Betarena Scores Aug 10, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Aug 10, 2023
@migbash migbash added this to the [FEATURE]: Competitions milestone Aug 10, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Aug 11, 2023
@migbash
Copy link
Collaborator

migbash commented Aug 14, 2023

Important
Target data has been moved from:

  • competitions/competitions_home_translations to competitions/translation_page_home
  • competitions/competitions_seo_homepage to competitions/seo_page_home

@migbash
Copy link
Collaborator

migbash commented Aug 15, 2023

Warning
@jonsnowpt Invalid data parameters in some of the (column) main_data in competitions/seo_page_home. Please correct to valid type, using the link found in 💠 Data Handling note in Obsidian for target table > column, marked as (DATA), to validate the expected type for said (column).

Wrong type example:

"noindex": "Falso", // incorrect, expected boolean.
"nofollow": "Falso", // incorrect, expected boolean.

@jonsnowpt
Copy link
Contributor Author

@migbash

Check now.

@migbash migbash moved this from In Progress to Staging in Betarena Scores Aug 15, 2023
@migbash
Copy link
Collaborator

migbash commented Aug 15, 2023

Warning
@jonsnowpt Invalid data for (column) data in competitions/translation_page_home, for the use of the \n. Should be <br /> instead, as per usual for the property: no_competitions.

Note
Also, best to wrap the Come back later text as a <p> tag, and have the 2 sentences separated by the <br /> tag.
or, even better would be to split the no_competition into no_competition_title: "Come back later" and no_competition_subtitle: "...".

@jonsnowpt
Copy link
Contributor Author

@migbash

Updated:

{"title":"Competitions","no_competition":"Come back later","no_competition_title":"No competitions available at the moment"}

@migbash migbash moved this from Staging to Testing in Betarena Scores Aug 16, 2023
@migbash
Copy link
Collaborator

migbash commented Aug 16, 2023

Note
❌ Active on dev from v805 - not updated to correct @betarena/scores-lib.
🟩 Active on dev from v806 - corrected from v805.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📣 [A] high priority Something that needs attention and accelerated resolving 🎨 Frontend
Projects
Archived in project
Development

No branches or pull requests

2 participants