Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Always showing the same ODDS #1776

Closed
4 of 12 tasks
jonsnowpt opened this issue Oct 18, 2023 · 10 comments
Closed
4 of 12 tasks

[Bug]: Always showing the same ODDS #1776

jonsnowpt opened this issue Oct 18, 2023 · 10 comments
Assignees
@jonsnowpt
Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving 🚨 [A] urgent An urgent action needed on something
Milestone
[CORE]: General

Comments

@jonsnowpt
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

🐞 Describe the bug

The platform is now showing the same odds for all fixtures:

RPReplay_Final1697623758.MP4

🤔 Expected Behavior

Should load different odds.

What environment is the bug/issue detected in.

  • Production (scores.betarena.com)
  • Development

What browsers are you seeing the problem on?

  • Firefox
  • Chrome
  • Safari
  • Microsoft Edge
  • Brave
  • Opera

What device/platform can the problem be seen?

  • 📱 Mobile
  • 💻 Tablet
  • 🖥️ Laptop/Desktop

Steps To Reproduce

Visit different fixtures.

Console Logs (if any)

No response

Anything else?

This issue started to happen after the last release.
@jonsnowpt jonsnowpt added 🐞 [A] bug Something isn't working. Needs to be looked at. 🎨 Frontend labels Oct 18, 2023
@jonsnowpt jonsnowpt added 📣 [A] high priority Something that needs attention and accelerated resolving 🚨 [A] urgent An urgent action needed on something and removed 🎨 Frontend labels Oct 18, 2023
@jonsnowpt jonsnowpt moved this to Todo in Betarena Scores Oct 18, 2023
@migbash migbash added this to the General milestone Oct 18, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 18, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 18, 2023 •
edited
Loading

Note
Corrected, awaiting 🚀 deployment.

🔍 CAUSE
The data point for sessionStore.live_odds_fixture_target = [..] is shared amongst Featured Match (Home Page) widget and in this case the Scoreboard (Fixture Page) widget, causing for the Scoreboard widget data to use that of the Featured Match when navigating on the Scores Platform under the same session.

🟩 SOLUTION
Data is now refreshed, and properly adjusted to null-ify for this specific case, even when navigating between pages (like in the case of this issue).

Note
In addition, because the Scoreboard (Fixture Page) widget was not dynamically loaded, but rather directly imported, the svelte reactivity $: [..] would trigger immediately upon page load, causing the front-run of the previously set Featured Match (Homepage) data for 1X2 odds, before there is a chance for the new data to be fetched, which occurs onMount(..). This has been adjusted as an additional condition check (in conjuction with the beforeNavigate(..), to null-ify the data point and show the correct data every time.

@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 18, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Live on dev from v880.

@migbash migbash removed the status in Betarena Scores Oct 19, 2023
@migbash migbash moved this to Testing in Betarena Scores Oct 19, 2023
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 19, 2023
migbash added a commit that referenced this issue Oct 19, 2023
@migbash
#1776 :: fix;
3aadcdd
@migbash
Copy link
Collaborator

migbash commented Oct 19, 2023

Note
Took into effect as of v.X.Y.Z (via patch hot-fix).

@jonsnowpt
Copy link
Contributor Author

jonsnowpt commented Oct 19, 2023 •
edited by migbash
Loading

@migbash

We still have issues here.

The odds now are not repeated, but we still get the undefined error that should not occur:

  • [..]/football/san-marcos-juventud-la-joya-19024641
  • [..]/pt/futebol/palmeiras-atltico-mineiro-18791301

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Oct 19, 2023
@jonsnowpt jonsnowpt assigned migbash and unassigned jonsnowpt Oct 19, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 19, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 20, 2023

Note
Still seen to be happening :: slack

@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 20, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 21, 2023

Note
Corrected, awaiting 🚀 deployment.

@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 21, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 21, 2023

Note
Live on dev from v887.

migbash added a commit that referenced this issue Oct 21, 2023
@migbash
#1776 :: fix - probability widget;
3737e0e
migbash added a commit that referenced this issue Oct 21, 2023
@migbash
#1776 :: fix - scoreboard widget;
b959094
migbash added a commit that referenced this issue Oct 21, 2023
@migbash
Migbash/issue-1784 | Sentry Errors (#1796)
8652c5f 
* fs :: move app.d.ts to types/*

* #1776 :: fix - probability widget;

* #1776 :: fix - scoreboard widget;

* #1791 :: fix - probability widget odds;

* fix :: +layout.svelte invalid route.id check;

* fix :: Header-Nav-Btn.svelte invalid route.id check;

* fix :: Header.svelte invalid route.id check;

* core :: platform-functions.ts 'dev' ignore redirect;

* fix :: patform-functions.ts invalid route.id check;

* feat :: improved error message of invalid url routes

* feat :: improved error message of invalid url routes (client)

* types :: add app.d.ts for Error (global);

* fix :: hooks.server.ts default error code + msg;

* fix :: fixture +page.ts update error handle;

* pkg :: scores-lib 1.8.2;
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 21, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Oct 21, 2023
@migbash migbash moved this from Done to Todo in Betarena Scores Oct 22, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 22, 2023 •
edited
Loading

Issue 1

Note
The issue of the odds mirroring (a.k.a using that of the Featured Match) has been registered again slack-conversation-1, slack-conversation-2,

It appears that the firebase-real-time listener is somehow still using the listener which was set on the homepage. So, it seems the connection needs to be obliterated to prevent the odds from the featured match to act upon the data. Although, fixtureId checks are made to prevent the use of the _1x2 odds, but nonetheless, a re-check is required.

🟩 SOLUTION
Call the featured match method callback from firebase for Unsubscribed to obliterate the listener setup, before the navigation page occurs.

Issue 2

It appears that some flickering can be detected on the reset of the odds data, that was added to prevent the leaking of those from the featured match.

🟩 SOLUTION
This has now been fixed, to only null-ify the odds when the condition calls for it (i.e. :: when odds are from a different gameId, etc.) and are only reset on page-load.

Note
Corrected, awaiting 🚀 deployment.

Note
Live on dev from v891.

@migbash migbash assigned migbash and unassigned jonsnowpt Oct 22, 2023
@migbash migbash reopened this Oct 22, 2023
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 22, 2023
@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 24, 2023
@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 24, 2023
migbash added a commit that referenced this issue Oct 24, 2023
@migbash
#1776 :: fix;
7448201
@jonsnowpt
Copy link
Contributor Author

@migbash

Still having issues:

https://betarena.slack.com/archives/D02B1UHEECS/p1698144324706619

@jonsnowpt jonsnowpt moved this from Testing to Todo in Betarena Scores Oct 24, 2023
migbash added a commit that referenced this issue Oct 24, 2023
@migbash
#1776 :: fix;
6ae1c4a
@migbash migbash moved this from Todo to In Progress in Betarena Scores Oct 24, 2023
@migbash
Copy link
Collaborator

migbash commented Oct 24, 2023 •
edited
Loading

Note
Caused because on the odds for fixture-id:: 18988224 the data is missing the gameId for the [0] odds, leading to an invalid data condition, that null-ifes the odds.

Note
Corrected, awaiting 🚀 deployment.

Note
Live on dev from v892.

@migbash migbash moved this from In Progress to Staging in Betarena Scores Oct 24, 2023
@migbash migbash moved this from Staging to Testing in Betarena Scores Oct 24, 2023
@migbash migbash assigned jonsnowpt and unassigned migbash Oct 24, 2023
@github-project-automation github-project-automation bot moved this from Testing to Done in Betarena Scores Oct 24, 2023
jonsnowpt pushed a commit that referenced this issue Oct 25, 2023
@migbash
minor (#1805)
eeb5b8f 
* core :: Makefile update;

* debug :: Sentry disable on local env; add logs;

* debug :: enhance color-coding;

* core :: Makefile update;

* Migbash/issue-1719 | fixture/competitions (#1795)

* Migbash/issue-1784 | Sentry Errors (#1796)

* fs :: move app.d.ts to types/*

* #1776 :: fix - probability widget;

* #1776 :: fix - scoreboard widget;

* #1791 :: fix - probability widget odds;

* fix :: +layout.svelte invalid route.id check;

* fix :: Header-Nav-Btn.svelte invalid route.id check;

* fix :: Header.svelte invalid route.id check;

* core :: platform-functions.ts 'dev' ignore redirect;

* fix :: patform-functions.ts invalid route.id check;

* feat :: improved error message of invalid url routes

* feat :: improved error message of invalid url routes (client)

* types :: add app.d.ts for Error (global);

* fix :: hooks.server.ts default error code + msg;

* fix :: fixture +page.ts update error handle;

* pkg :: scores-lib 1.8.2;

* Migbash/issue-1752 | competition lobby/highlights; (#1797)

* feat :: lobby/highlights data endpoint upgrade;

* doc :: OpenAPI update;

* feat :: Highlights-Grid-Row upgrade;

* feat :: Highlights-Grid upgrade;

* feat :: Highlights-Widget upgrade;

* core :: utils.ts update for 'white-space' removal of endpoints;

* pkg :: scores-lib 1.9.0;

* debug :: remove redundant console.log(..);

* #1798 :: fix;

* #1799 :: fix;

* #1776 :: fix;

* #1776 :: fix;

* test :: +page.server.ts;

* #1800 :: feat :: stable endpoint update limit;

* #1800 :: doc :: OpenApi update;

* pkg :: scores/lib 1.9.2

* Migbash/1801-FEATURE-Competitions-Cache (#1804)

* 🧪 :: test | debug :: performance improvements (2);

* #1801 :: feat :: extra corrections (cont);

* #1801 :: feat :: extra corrections (cont);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonsnowpt jonsnowpt

Labels
🐞 [A] bug Something isn't working. Needs to be looked at. 📣 [A] high priority Something that needs attention and accelerated resolving 🚨 [A] urgent An urgent action needed on something
Projects
Betarena Scores
Archived in project
Milestone
[CORE]: General
Development

No branches or pull requests
2 participants
@migbash @jonsnowpt