-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding husky used for forcing conventional commits format
add miscellenous target for mac-os target used for *_. files cleaning;
add setup target for quicker project spin-up and development;
add miscellenous target for MAKE target to signal completion;
add changelog support for the project.
add code-style.md for developer guideline on code structure, format and expectation;
add filesystem.md for developer guideline on project/filesystem used;
update targets for heroku (most) including secrets update (heroku-dev), targets for git (most) including git-commit and git-setup, targets for dotenv-vault support (init);
name change for README-DEV.md to _stash.md, containing stashed link resources used and encountered through the development of this project.
remove use of prettier from the project, unecessary opiniated code styling enforcing when project uses its own styles enforced with eslint.
add EsLint for project, including package.json and `.vscode/settings.json` update for `auto-fix` on save EsLint detected issues.
adding project badges
add comments, update targets to ignore;
updated for dotenv support;
changing the initial location for the custom-server files running under-the-hood for sveltekit into `server/`
add the latest v7.Widget.svelte boilerplate template;
initialize the use of the .env.vault for the project powered by dotenv;
adding documentation such as: `dependencies.md`, `errors.md`, `filesystem.md`, `setup.md` and `structure.md` related to the project.
updated README.md and split sections into separate docs/ files, and keep README.md as short and information rich as possible.
add to include the .env.example as part of git;
update make target fos (1) development (local) to include (dotenv), (2) heroku (prod) secrets target, (3) dotenv cleaning, as well as minor documentation patch up;
add dotenv-vault support for secrets decrypting on the fly;
initialize example for secrets.
update to inlcude development;
bring up to speed
correcting some incorrect targets for heroku deployments;
modified documentations for (1) `code-style.md`, (2) `setup.md` for more concise setup;
add CHANGELOG.md
updated Makefile targets for (1) heroku, merging the targets into dynamic argument accepting targets, (2) dotenv (same as for heroku), (3) git, correct to use git-stash on pull-request update, (4) miscellaneous, changelog-init target for CHANGELOG.md generation, + other minor changes; other documentation changes made also.
update Makefile targets for (1) logging, (2) ONESHELL use, (3) node-setup, (4) nvm-use
initialize .nvmrc for correct node expected version
Co-authored-by: acosta <ac@ba.com>
Please set the Pull-Request |
migbash
approved these changes
Jan 11, 2024
jonsnowpt
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please
click on
the(^) Preview
tab and select the appropriate sub-template: