Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method loginByKubeJwt for logging in with path, jwt and role #171

Closed
wants to merge 1 commit into from

Conversation

rabbitzzy
Copy link

This PR is to implement the vault auth for kubernetes mentioned in #170, please letme know if any questions. thanks!

@mrunesson
Copy link
Contributor

This is similar to #164 which also support generic jwt.

@zzhu2
Copy link

zzhu2 commented May 12, 2019

This is similar to #164 which also support generic jwt.

Totally agree. Thank you! @mrunesson Do you know what is the integration and release schedule of this repo?

@mrunesson
Copy link
Contributor

mrunesson commented May 13, 2019 via email

@steve-perkins
Copy link
Contributor

Thanks a lot @rabbitzzy! It looks like PR #164 basically provides the same functionality in a more generalized manner, so I'm getting ready to merge that one. Appreciate the contribution, however!

@rabbitzzy
Copy link
Author

rabbitzzy commented Jun 3, 2019 via email

@steve-perkins
Copy link
Contributor

@rabbitzzy: I'm making a pass through the backlog of outstanding PR's, and hope to have a Maven Central update out tomorrow or Wednesday. Whether it's a minor version or a major version bump depends on whether there are any breaking API changes, so I'm not sure yet what the actual artifact version will be.

@steve-perkins
Copy link
Contributor

Sorry, this Maven Central release is taking longer than I had hoped. One of the other PR's that I merged, #165, was supposed to add support for Java 9+ while maintaining compatibility with Java 8. Unfortunately, there was a misunderstanding, as I believed the library could still be built in a Java 8 environment. That turns out not to be true... the library now needs JDK 9+ on the build server to publish (I might have held off until the next release if I had fully grokked that).

I'll need to make some updates to the build environment tomorrow to support a newer version (11 LTS, probably), and cross my fingers that there aren't any issues importing the resulting library into a Java 8 test project (in which case I'd have to roll this back, as I'm not yet ready to drop support for the most widely-used Java version by a large margin).

@steve-perkins
Copy link
Contributor

FYI... I have a StackOverflow question open, to resolve the build issues that have prevented this latest version from going out. If anyone has any insights on this, that would be great:

https://stackoverflow.com/questions/56655050/how-to-setup-a-intellij-gradle-project-with-targetcompatibility-1-8-and-sourcec

@steve-perkins
Copy link
Contributor

I have resolved the build issues relating to Java 8 / 9+ compatibility, and updated the documentation for a 4.1.0 release. There are just some flaky integration tests standing between here and that publication.

Since this PR is closed, please see issue #170 for further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants