Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #22

Merged
merged 20 commits into from
Dec 11, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5206c32
Responsive redesign of the error page. (charliesome/better_errors#6)
rstacruz Dec 9, 2012
ecb0e7e
make the exception message more prominent
rstacruz Dec 10, 2012
6790988
firefox compatibility, and simplify the design a bit
rstacruz Dec 10, 2012
715634f
update colors
rstacruz Dec 10, 2012
574ccc2
fix repl line being too narrow
rstacruz Dec 10, 2012
2160814
highlight the stack trace method names differently
rstacruz Dec 10, 2012
0213587
update image in readme
rstacruz Dec 10, 2012
81c41d4
remove superfluous extra line on repl
rstacruz Dec 10, 2012
ad450c6
prevent horizontal scrollbars in firefox in the repl shell
rstacruz Dec 10, 2012
7daf8ff
fix floatdropping on stack trace names in single-column mode
rstacruz Dec 10, 2012
d441a47
make layout more responsive by not clipping the header text in skinny…
rstacruz Dec 10, 2012
61a91d0
show only application frames by default
rstacruz Dec 10, 2012
68b5862
go for a slightly flatter look
rstacruz Dec 10, 2012
b4c2a7c
show filename more prominently in frame info
rstacruz Dec 10, 2012
eb14017
highlight offending line on load
rstacruz Dec 10, 2012
4e50dd7
style the 'source unavailable' message
rstacruz Dec 10, 2012
abea3b5
memoize the name-splitting regex
rstacruz Dec 11, 2012
e01dc40
show full exception message on hover; truncate message to 5 lines
rstacruz Dec 11, 2012
9b9b7e8
remove annoying extra white line in 1-column mode
rstacruz Dec 11, 2012
69a327c
limix max-height of long vardumps, and prevent superwide vardumps
rstacruz Dec 11, 2012
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Better Errors replaces the standard Rails error page with a much better and more useful error page. It is also usable outside of Rails in any Rack app as Rack middleware.

![image](http://i.imgur.com/urVDW.png)
![image](http://i.imgur.com/Me5of.png)

## Features

Expand Down
2 changes: 1 addition & 1 deletion lib/better_errors/code_formatter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def html
end

def source_unavailable
"<p>Source unavailable</p>"
"<p class='unavailable'>Source unavailable</p>"
end

def coderay_scanner
Expand Down
12 changes: 12 additions & 0 deletions lib/better_errors/stack_frame.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,18 @@ def gem_path
end
end
end

def name_parts
@name_parts ||= name.match(/^(.*?)([\.\#].*)$/)
end

def class_name
name_parts && name_parts[1]
end

def method_name
name_parts && name_parts[2]
end

def context
if application?
Expand Down
Loading