Spec fix/workaround (in README and in webvalve/rspec) #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/domain @Betterment/webvalve-core @samandmoore @effron
/no-platform
It looks like #40 was merged but
never released until 1.0.0[correction: it was released but we never pulled it into our app] -- I noticed a regression in our local app due to the way our tests had been configured:Unfortunately, "setup" now raises every time due to duplicate stubs.
This PR updates the rspec helper and the README to include the fix I made to the local app, but I'm wondering if this merits a slightly different API so that test-resets can be handled in a single command.
Maybe
WebValve.reset
should implicitly callsetup
again? And maybe we need aWebValve.clear
that does what reset currently does and clears everything without setting up?(Just brainstorming 🤔)