Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec fix/workaround (in README and in webvalve/rspec) #43

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

smudge
Copy link
Member

@smudge smudge commented Apr 23, 2020

/domain @Betterment/webvalve-core @samandmoore @effron
/no-platform

It looks like #40 was merged but never released until 1.0.0 [correction: it was released but we never pulled it into our app] -- I noticed a regression in our local app due to the way our tests had been configured:

  config.around :each do |ex|
    WebValve.setup
    ex.run
  end

Unfortunately, "setup" now raises every time due to duplicate stubs.

This PR updates the rspec helper and the README to include the fix I made to the local app, but I'm wondering if this merits a slightly different API so that test-resets can be handled in a single command.

Maybe WebValve.reset should implicitly call setup again? And maybe we need a WebValve.clear that does what reset currently does and clears everything without setting up?

(Just brainstorming 🤔)

@nanda-prbot
Copy link

Needs somebody from @Betterment/webvalve-core, @samandmoore, and @effron to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@smudge smudge changed the title Document spec fix/workaround in README (for now) Spec fix/workaround (in README and in webvalve/rspec) Apr 23, 2020
@effron
Copy link
Contributor

effron commented Apr 24, 2020

<<domainLGTM

@nanda-prbot
Copy link

Approved! 🚢 🙆‍♀️ 💥

@samandmoore samandmoore merged commit 56f836b into master Apr 24, 2020
@samandmoore samandmoore deleted the duplicate-stub-warning branch April 24, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants