Ensure that all configs are reloaded after reset + setup #44
Conversation
|
Needs somebody from @samandmoore and @effron to claim domain review Use the shovel operator to claim, e.g.:
|
|
I wonder if we can move the config loading after the check for enabled? It would be different from how things work right now but might be an improvement that avoids loading those files unless they need to be loaded? I can't think of anything that they'd need to be loaded for if setup is going to no op |
This makes sense -- I went ahead and made the change. Not seeing anything break locally when I point apps to it. |
| def load_configs! | ||
| WebValve.config_paths.each do |root| | ||
| path = root.join('config', 'webvalve.rb').to_s | ||
| load path if File.exist?(path) |
There was a problem hiding this comment.
Don't love that we're doing ruby file io on every test case now, but we can look to optimize if it seems to actually be slow.
|
Okay. Let's do this! <<domainlgtm platformlgtm |
|
Approved! 🎁 🙌 👌 |
/domain @samandmoore @effron
/platform @samandmoore @effron