Replace File.exists? with File.exist? for Ruby 3.2 compatibility #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmnsun
changed the title
|
Thanks Andrei, great catch. This is making us realize we have a gap on ruby deprecation handling, which we'd like to inbox zero. Since we're angling toward a 2.0 release to support URL wildcards, we'll try to get this patch in along with a better story for proactively identifying deprecations even before they start failing in production. Of course doubly an issue here was that it's in a generator, which are tricky to test, and not tested. I think we'll take this patch as is and then see about adding extra testing and deprecation safety. |
|
hi @tmnsun, I just pushed a 1.3.1 release with this fix to get it out sooner than the 2.0.0 release since that might be a minute 😄 Thanks again for reporting this and fixing it |
|
Thank you! That was fast :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
File.exists?withFile.exist?due to removal of the former method in Ruby 3.2, ensuring compatibility with the latest Ruby versions