Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action failing with out of range array #15

Closed
jpacareu-meli opened this issue Jul 29, 2020 · 3 comments
Closed

Action failing with out of range array #15

jpacareu-meli opened this issue Jul 29, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@jpacareu-meli
Copy link
Contributor

jpacareu-meli commented Jul 29, 2020 •
edited
Loading

Describe the bug
Hi I'm having this error quite a lot with the action.

image

Is there any chance that we have a fallback meme URL in case default one fails?
@jpacareu-meli jpacareu-meli added the bug Something isn't working label Jul 29, 2020
@Bhupesh-V
Copy link
Owner

Hi @jpacareu-meli 👋🏽
Thanks for reporting this. I too have started having this problem now 😅
I think a fallback meme would be a Good Idea moreover we can provide input fields for this

uses: Bhupesh-V/memer-action@master
with:
    filter: "new"
    default_meme: ""
    default_source: ""
    default_title: ""

What do you think?

Bhupesh-V added a commit that referenced this issue Jul 31, 2020
@Bhupesh-V
getting ready for 0.3.0 release
4e86094 
- possible fixe #15
- show error message while using "filter"
@jpacareu-meli
Copy link
Contributor Author

Excelent solution 💪

@Bhupesh-V
Copy link
Owner

Fixed in 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bhupesh-V @jpacareu-meli