-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Histogram1D if the same measurement is selected for both axes #237
Conversation
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 82.30% 75.63% -6.67%
==========================================
Files 14 14
Lines 1565 1650 +85
==========================================
- Hits 1288 1248 -40
- Misses 277 402 +125
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- histogram colors still need to be updated (something like this may work: https://stackoverflow.com/a/49290555/11885372)
Hi @lazigu , sorry for the delay! |
for more information, see https://pre-commit.ci
The histogram still needs to be painted back with the right colors. As metnioned in the commit, somthing like this may work: https://stackoverflow.com/a/49290555/11885372 This is a work in progress. |
Hi @lazigu, hi everyone, the span selection should be working now. The histogram colors now also get updated, having a similar behavior to the other plotting options (histogram 2d and scatter). I renamed the If both measurements are the same, the histogram is 1D and a span selector is used instead of the lasso. Right-click should reset the clusters. Could someone test before merging? Best, |
This PR implements plotting 1D histogram if the same measurement is selected for both axes. Currently, no clustering for this type of histogram is implemented. @zoccoler had an idea that clustering for such a histogram could be done with a span selector (the issue has not been created yet).
Partly closes #151, however, a separate issue regarding clustering 1D histograms should be created.