Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering error after edit chapter action with no audio (OT-866 Cont) #1134

Merged

Conversation

darrellcolehill
Copy link
Collaborator

@darrellcolehill darrellcolehill commented Apr 26, 2024

Opening a blank chapter in OcenAudio then closing OcenAudio without adding any recording caused verseNodes to have sectors with negative end values.


This change is Reviewable

This happens when you open a blank chapter in OcenAudio, then close OcenAudio without adding any recording.
Copy link
Collaborator

@jsarabia jsarabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@jsarabia jsarabia merged commit e3bc638 into dev May 1, 2024
9 of 10 checks passed
@jsarabia jsarabia deleted the dh-ocenAudio-without-recording-causes-rendering-error branch May 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants