Optimize source import #1138
Merged
Optimize source import #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsarabia
requested changes
May 3, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @AnonymousWalker)
assets/src/main/kotlin/org/wycliffeassociates/otter/assets/initialization/InitializeProjects.kt line 122 at r1 (raw file):
} private fun migrateSourcesToVersion2() {
let's keep the naming convention consistent
AnonymousWalker
commented
May 6, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jsarabia)
assets/src/main/kotlin/org/wycliffeassociates/otter/assets/initialization/InitializeProjects.kt line 122 at r1 (raw file):
Previously, jsarabia (Joe) wrote…
let's keep the naming convention consistent
Done.
jsarabia
approved these changes
May 6, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores sources as directories instead of zip
This change is