Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word-align wav total audio length to correctly parse metadata #1152

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Word-align wav total audio length to correctly parse metadata #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6acf93
Word-align wav total audio length to correctly parse metadata
mXaln Jun 5, 2024
79a124c
word-align audio data, so it's size is never an odd number
mXaln Jun 6, 2024
fb0ebfb
removed constant
mXaln Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/audio/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group = 'org.wycliffeassociates.otter.common'
version = '0.4.2'
version = '0.4.3'

dependencies {
testImplementation "junit:junit:$junitVer"
Expand Down
2 changes: 1 addition & 1 deletion common/audio/src/main/kotlin/org/wycliffeassociates/otter/common/audio/wav/WavFile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class WavFile private constructor() : AudioFormatStrategy {
val metadataSize = totalDataLength - nonMetadataSize
val bytes = ByteArray(metadataSize)
file.inputStream().use {
val metadataStart = headerSize + totalAudioLength
val metadataStart = headerSize + wordAlign(totalAudioLength)
it.skip(metadataStart.toLong())
it.read(bytes)
}
Expand Down
2 changes: 1 addition & 1 deletion common/audio/src/test/kotlin/org/wycliffeassociates/otter/common/audio/wav/CueChunkTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class CueChunkTest {
}
val os = WavOutputStream(wav)
os.use {
os.write(ByteArray(writeSize))
os.write(ByteArray(wordAlign(writeSize)))
}
val validator = WavFile(file, WavMetadata(listOf(CueChunk())))
val resultMetadata = validator.metadata
Expand Down
Loading