Support multiple resource selection in Project Wizard #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymousWalker
changed the title
jsarabia
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 17 files reviewed, 1 unresolved discussion (waiting on @AnonymousWalker)
jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/viewmodel/HomePageViewModel2.kt line 215 at r1 (raw file):
// projectWizardViewModel.existingLanguagePairs.remove( // Pair(cardModel.sourceLanguage, cardModel.targetLanguage) // )
should this get deleted, or does it need to get fixed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can select from the list of available source versions (ULB, UDB, F10...).
This also retains the quick-project-creation to skip the remaining steps whenever applicable. For example:
Narration mode is selected and a source language is selected, if there's a single version (ULB), the UI will bypass step 3, 4 and proceed to create the project.
This change is