Felix/sdk #19
Merged
Felix/sdk #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[generate_trait] | ||
| impl WrapFactoryInterfaceImpl of WrapFactoryInterface { | ||
| fn create_wrap_address(ref self: ContractState, erc1155_address: ContractAddress, token_id: u256, name: felt252, symbol: felt252) { | ||
| let wrap_address = self.map.read((erc1155_address, token_id)); |
There was a problem hiding this comment.
should move this to helper fn
| import JSBI from 'jsbi'; | ||
|
|
||
|
|
||
| export abstract class TickMath { |
There was a problem hiding this comment.
this shouldn't be a class but rather just be helper functions
| const sortedTokens: Contract[] = [Wrap.ERC20Contract, Wrap.WERC20Contract].sort((a, b) => a.address.localeCompare(b.address)); | ||
|
|
||
|
|
||
| const approveForAll: Call = { |
There was a problem hiding this comment.
These Calls should be outside of this function so they can be composed
| const werc20AmountIn = BigInt(erc1155AmountIn.toString()) * BigInt(10 ** 18); | ||
| Decimal.set({ precision: 78 }); | ||
| let sqrtRatioLimitX128 = (Wrap.ERC20Contract.address < Wrap.WERC20Contract.address) ? new Decimal(currentPrice / 300).sqrt().mul(new Decimal(2).pow(128)).toFixed(0) : new Decimal(currentPrice * 300).sqrt().mul(new Decimal(2).pow(128)).toFixed(0); |
There was a problem hiding this comment.
these is hard to understand - could it be decoupled?
| // TODO check length | ||
| const sortedTokens: Contract[] = [Wrap.ERC20Contract, Wrap.WERC20Contract].sort((a, b) => a.address.localeCompare(b.address)); | ||
| if (slippage < 0 || slippage > 1) { |
There was a problem hiding this comment.
this could be helper function
| let sqrtRatioLimitX128 = (Wrap.ERC20Contract.address < Wrap.WERC20Contract.address) ? new Decimal(currentPrice / 300).sqrt().mul(new Decimal(2).pow(128)).toFixed(0) : new Decimal(currentPrice * 300).sqrt().mul(new Decimal(2).pow(128)).toFixed(0); | ||
|
|
||
| const approveForAll: Call = { |
There was a problem hiding this comment.
Calls should be outside of this function for composibility
| const tokenIdCairo = cairo.uint256(tokenId); | ||
| const balance = await Wrap.ERC1155Contract.balance_of(address, tokenIdCairo); | ||
| return balance |
There was a problem hiding this comment.
Suggested change
| return balance | |
| return await Wrap.ERC1155Contract.balance_of(address, tokenIdCairo); |
refactor wrap.ts code. Move duplicate code to standalone function.
1. moved types to standalone file 2. passed account to wrap function as parameters 3. removed some useless code
sdk-refactor
examples/interface/package-lock.json
Outdated
There was a problem hiding this comment.
this isn't needed if bun exists
Remove liquidity
| const [positionId, setPositionId] = useState(0); | ||
| const [liquidity, setLiquidity] = useState(0); | ||
|
|
||
| const erc1155_address = useMemo( |
There was a problem hiding this comment.
these can just be const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.