Warn users if security is implicitly disabled

BigPandaToo · Mar 16, 2021 · 16d858c · 16d858c
1 parent 6b56c8d
commit 16d858c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/docs/build.gradle b/docs/build.gradle
@@ -47,6 +47,7 @@ testClusters.matching { it.name == "integTest"}.configureEach {
     keystorePassword 'keystore-password'
   }
 
+  setting 'xpack.security.enabled', 'false'
   // enable regexes in painless so our tests don't complain about example snippets that use them
   setting 'script.painless.regex.enabled', 'true'
   setting 'path.repo', "${buildDir}/cluster/shared/repo"

diff --git a/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java b/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java
@@ -81,10 +81,6 @@
  *
  */
 public class DoSection implements ExecutableSection {
-    private final String SecurityDisabledWarningHeaderPattern = "Elasticsearch built-in security features are not enabled, your cluster may " +
-        "be accessible without authentication. Read https:\\/\\/www\\.elastic\\.co\\/guide\\/en\\/elasticsearch\\/reference" +
-        "\\/(\\d+\\.)(\\d+)(\\.\\d+)?\\/get-started-enable-security\\.html for more information";
-
     public static DoSection parse(XContentParser parser) throws IOException {
         String currentFieldName = null;
         XContentParser.Token token;
@@ -383,7 +379,6 @@ void checkWarningHeaders(final List<String> warningHeaders, final Version master
                 .map(HeaderWarning::escapeAndEncode)
                 .collect(toCollection(LinkedHashSet::new));
         final Set<Pattern> allowedRegex = new LinkedHashSet<>(allowedWarningHeadersRegex);
-        allowedRegex.add(Pattern.compile(SecurityDisabledWarningHeaderPattern));
         final Set<String> expected = expectedWarningHeaders.stream()
                 .map(HeaderWarning::escapeAndEncode)
                 .collect(toCollection(LinkedHashSet::new));