Skip to content

Commit

Permalink
Revert "Temporary restrict Wago versions"
Browse files Browse the repository at this point in the history
This reverts commit 1d6aa80.
This reverts commit 246f52d.
  • Loading branch information
nebularg committed May 8, 2024
1 parent 246f52d commit 07a3e3c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ For a full example workflow, please check out the [wiki page](https://github.com
When detecting versions, the `package-as` TOC file is parsed first, then TOC
files in `move-folders` paths. In v2.2.2, the first interface value found
for a game type was used and the rest were ignored. So if you had 100207 in
your main TOC file, but missed updating 100205 in your modules, the final
your main TOC file, but missed updating 100206 in your modules, the final
version would just be `10.2.7`. But now the final version will include *all*
interface versions, meaning it will be `10.2.7,10.2.5`.
interface versions, meaning it will be `10.2.7,10.2.6`.

You can still use `-g` to override version detection entirely, but it is
still kind of the nuclear option.
Expand All @@ -50,9 +50,6 @@ For a full example workflow, please check out the [wiki page](https://github.com
original TOC file is not included.
4. The base `## Interface:` doesn't affect splitting, and will just be carried
through to the fallback TOC file.
5. Wago is still finalizing support for multiple versions per game type, until
complete, the Wago versions are restricted to the current live version of
each game type.

## Customizing the build

Expand Down Expand Up @@ -311,7 +308,7 @@ Era interface version first, all three game clients will load the addon
correctly.

That said, just because you *can* include a bunch of interface versions doesn't
mean you should start adding upcoming versions you haven't testing your addon
mean you *should* start adding upcoming versions you haven't tested your addon
against.

### Single game version
Expand Down
5 changes: 2 additions & 3 deletions release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2927,8 +2927,7 @@ upload_wago() {
fi

local _wago_versions _wago_game_version _wago_support_property
# _wago_versions=$( curl -s https://addons.wago.io/api/data/game | jq -c '.patches' 2>/dev/null )
_wago_versions='{"retail":["10.2.7"],"cata":["4.4.0"],"wotlk":["3.4.3"],"bc":["2.5.4"],"classic":["1.15.2"]}' # XXX single version compat
_wago_versions=$( curl -s https://addons.wago.io/api/data/game | jq -c '.patches' 2>/dev/null )
if [ -n "$_wago_versions" ]; then
_wago_support_property=
local wago_type wago_game_type_version invalid_version
Expand Down Expand Up @@ -2962,7 +2961,7 @@ upload_wago() {
fi
done
if [[ -n $wago_game_type_version ]]; then
_wago_support_property+="\"supported_${wago_type}_patch\": ${wago_game_type_version#,}, " # XXX single version compat
_wago_support_property+="\"supported_${wago_type}_patches\": [${wago_game_type_version#,}], "
fi
done
_wago_game_version=$( echo "${_wago_game_version#,}" | tr ',' '\n' | sort -Vr | tr '\n' ',' )
Expand Down

0 comments on commit 07a3e3c

Please sign in to comment.