Fix out-of-bounds read in wingui implementation (#312)

Found with address sanitizer
Bill-Gray · Dec 12, 2023 · 70d2724 · 70d2724
1 parent 02a61c1
commit 70d2724
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/wingui/pdcdisp.c b/wingui/pdcdisp.c
@@ -399,7 +399,7 @@ static void PDC_transform_line_given_hdc( const HDC hdc, const int lineno,
         srcp -= x;
         x = 0;
     }
-    if( (srcp[len] & A_CHARTEXT) < MAX_UNICODE)
+    if( len < SP->cols - x && (srcp[len] & A_CHARTEXT) < MAX_UNICODE)
        len++;    /* draw an extra char to avoid leaving garbage on screen */
     if( len > SP->cols - x)
         len = SP->cols - x;