-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS/TS object-literal key have the same highlight color #87
Comments
What color do you think it should be |
Just make a distinction between key & value, they are the same color now...Before 2.8.3, the key's color is yellow |
I also was fine with the previous color, this annoys me, too. I would like to see the changes being reversed. |
But now, having a key and then an integer or boolean as the key we don't get any difference. |
It's OK, I just want a different color between them, I suggest the second color above picture(yellow?), and the integer's color, you can set it purple |
Good! but integer & boolean, could you just try purple? |
I think that would be bad @slieo @jens1o ,they have same scope |
😭 |
It's a tough choice |
Yep, @slieo's right. |
I'm fine with this. Thanks for your effort. :) |
@slieo |
You are right, but I don't know what color is better |
OK, thanks, Em...I want back to 2.8.2, but I don't konw how to operate... |
I think red is good |
Yeah, I also think it was best, but I didn't want to make you sad, because I like your effort. |
Thanks! |
Maybe keys should be white like in Atom unless they are strings? |
After update to 2.8.3, JS/TS object-literal key's color changes to green, and it's same as the value's color, please fixed it.
The text was updated successfully, but these errors were encountered: