Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS/TS object-literal key have the same highlight color #87

Closed
slieo opened this issue Jun 2, 2017 · 28 comments
Closed

JS/TS object-literal key have the same highlight color #87

slieo opened this issue Jun 2, 2017 · 28 comments

Comments

@slieo
Copy link

slieo commented Jun 2, 2017

After update to 2.8.3, JS/TS object-literal key's color changes to green, and it's same as the value's color, please fixed it.

@Binaryify
Copy link
Owner

Binaryify commented Jun 2, 2017

What color do you think it should be
In Atom, it was green

@slieo
Copy link
Author

slieo commented Jun 2, 2017

Just make a distinction between key & value, they are the same color now...Before 2.8.3, the key's color is yellow

@slieo
Copy link
Author

slieo commented Jun 2, 2017

@Binaryify
Copy link
Owner

How about this
image
image

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

I also was fine with the previous color, this annoys me, too. I would like to see the changes being reversed.

@Binaryify
Copy link
Owner

Binaryify commented Jun 2, 2017

before this, it was red, it maybe make some confusing
Like this
image
image

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

But now, having a key and then an integer or boolean as the key we don't get any difference.

@slieo
Copy link
Author

slieo commented Jun 2, 2017

It's OK, I just want a different color between them, I suggest the second color above picture(yellow?), and the integer's color, you can set it purple

@Binaryify
Copy link
Owner

How about this
@slieo @jens1o
image

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

sorry, but what me really annoys is still not how I would like it:

image
I would like to see a difference between a key and a value.

@slieo
Copy link
Author

slieo commented Jun 2, 2017

Good! but integer & boolean, could you just try purple?

@Binaryify
Copy link
Owner

Binaryify commented Jun 2, 2017

I think that would be bad @slieo @jens1o ,they have same scope
image
![image](https://cloud.githubusercontent.com/assets/12221718/26717361/b3cbdafc-47af-11e7-
image

image

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

😭

@Binaryify
Copy link
Owner

@slieo @jens1o
image
Maybe Atom is right?

@slieo
Copy link
Author

slieo commented Jun 2, 2017

It's a tough choice

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

Yep, @slieo's right.

@Binaryify
Copy link
Owner

image
How about this, left is VS Code, right is Atom

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

I'm fine with this. Thanks for your effort. :)

@Binaryify
Copy link
Owner

@slieo
How about you

@slieo
Copy link
Author

slieo commented Jun 2, 2017

this can't solve my problem, when the values are all string, just like this

@Binaryify
Copy link
Owner

You are right, but I don't know what color is better

@slieo
Copy link
Author

slieo commented Jun 2, 2017

OK, thanks, Em...I want back to 2.8.2, but I don't konw how to operate...

@Binaryify
Copy link
Owner

But in 2.8.2, it was red, like this
image

@slieo
Copy link
Author

slieo commented Jun 2, 2017

I think red is good

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

Yeah, I also think it was best, but I didn't want to make you sad, because I like your effort.

@Binaryify
Copy link
Owner

@slieo @jens1o
Will rollback to 2.8.2

@jens1o
Copy link
Collaborator

jens1o commented Jun 2, 2017

Thanks!

@iddan
Copy link

iddan commented Jun 14, 2017

Maybe keys should be white like in Atom unless they are strings?

Binaryify added a commit that referenced this issue Aug 8, 2019
Binaryify added a commit that referenced this issue Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants