-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Port to VSCode #17
Conversation
There's no need to support a dark version for the cv style 🤔 |
Yes, you're right. But in the VS Code preview, it is displayed according to the IDE theme. |
Fixed in 7d388bc. PDF generation style is not touched. Not preferring setting the preview background white, because it may cause eye damage to dark mode users working at midnight🤣 This commit just sets color & bg color properties as |
Feel free to keep the changes! |
README.md
Outdated
但页边距需要在 VSCode 设置中修改: | ||
|
||
1. 打开 VSCode 设置,选中 Workspace 标签页。 | ||
2. 搜索 Markdown-pdf › Margin,并修改四边边距。<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉只留第二种方法就行?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose method 2 to be the main one, and preserved method 1 as an alternative method.
|
||
1. 下载 [Release](https://github.com/BingyanStudio/LapisCV/releases/latest) 并解压至某一文件夹。 | ||
2. 在 VSCode 中打开该文件夹,并安装插件 [Markdown PDF](https://marketplace.visualstudio.com/items?itemName=yzane.markdown-pdf)。 | ||
3. 打开模版文件 [template.md](vscode/template.md) 进行内容编辑,右键选择 Markdown PDF - Export (pdf) 即可导出 PDF 文件。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
到时候发 release 的话,vscode 的版本是单独打包 vscode 这个子目录的,因此 .vscode 需要放在 vscode 子目录下,这边的安装步骤也需要调整下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave vscode/template.md as it is to ensure relative path relationship.
@media screen { | ||
img[alt="avatar"] { | ||
top: 1mm; | ||
right: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should adjust the position of the avatar in the preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@media screen {
img[alt="avatar"] {
position: relative;
top: 0;
right: 0;
}
}
Add VSCode version and corresponding guide to enhance usability for newcomers.
Providing rendered version below:
template.pdf