Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocolLimitation property defined 3 times in LabProtocol #435

Open
AlasdairGray opened this issue Jul 31, 2020 · 7 comments
Open

protocolLimitation property defined 3 times in LabProtocol #435

AlasdairGray opened this issue Jul 31, 2020 · 7 comments
Assignees

Comments

@AlasdairGray
Copy link
Member

LabProtocol has three definitions for the property protocolLimitation

@ljgarcia
Copy link
Contributor

ljgarcia commented Aug 3, 2020

@AlasdairGray it should be fixed in DRAFT_0.4 already added but not visible yet, visibility is fixed with PR BioSchemas/bioschemas.github.io#308

@ljgarcia
Copy link
Contributor

ljgarcia commented Aug 3, 2020

Hi @AlasdairGray have a look at https://bioschemas.org/profiles/LabProtocol it is pointing now to the latest version. Also, please have a look at #331. From the conversation, it looks like you talked at some point with @alaninmcr. I am not sure what of his comments still stand and not sure about the meaning of some of them. Any help is appreciated.

@ljgarcia
Copy link
Contributor

ljgarcia commented Aug 3, 2020

@AlasdairGray
Corrected link: https://bioschemas.org/profiles/LabProtocol/0.4-DRAFT-2020_07_23/
If I go to https://bioschemas.org/profiles/ 0.4_DRAFT is the one displayed but https://bioschemas.org/profiles/LabProtocol still takes me to the previous version. What other page should I update to get it right?

@ljgarcia
Copy link
Contributor

ljgarcia commented Aug 3, 2020

@AlasdairGray and how should we update the corresponding type?

@AlasdairGray
Copy link
Member Author

I discovered this problem when updating the type the other evening so was not referring to the profile. It is good to hear that it has been resolved there.

The type should be updated on the BioChemEntity branch of the schemaorg repo. Probably just a case of updating the turtle file here to match what you have done in the profile.

@ljgarcia
Copy link
Contributor

ljgarcia commented Aug 3, 2020

@AlasdairGray please have a look at BioSchemas/schemaorg#10
And, any suggestions on how to make https://bioschemas.org/profiles/LabProtocol to point to the latest draft? If I go to https://bioschemas.org/profiles/ 0.4_DRAFT is the one displayed but https://bioschemas.org/profiles/LabProtocol still takes me to the previous version. What other page should I update to get it right?
Thanks.

@ljgarcia
Copy link
Contributor

@AlasdairGray can we close this issue? Is it fully covered by the PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants