Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LabProtocol type acc. to 0.4_DRAFT profile #10

Draft
wants to merge 6 commits into
base: BioChemEntity
Choose a base branch
from

Conversation

ljgarcia
Copy link
Collaborator

@ljgarcia ljgarcia commented Aug 3, 2020

Changes regarding the 0.4_DRAFT profile:

  • isPartOf has range CreativeWork and URL (in the profile it is CreativeWork and Trip but Trip should be URL, it will be fixed together with definition as per issue 311 request)
  • isBasedOn included range Product that was removed from the profile (as this is the type, we should keep the original ranges already included in schema.org)

New updates included corresponding to 0.5_DRAFT profile:

  • Protocol advantage property description updated, see issue 440
  • Time properties updated (totalTime as it was plus performTime and prepTime as optional), see issue 441
  • ReagentUsed property description updated, now using CHEBI definition, also MolecularEntity and ChemicalSubstance to the range list added, see issue 442
  • Other changes such as description and headline (aka title) do not require changes on the type as they come from CreativeWork

Pending: Include href in comments as it is done in the profiles and in schema.org (not sure how to do so in ttl)

Changes regarding the 0.4_DRAFT profile:
* isPartOf has range CreativeWork and URL (in the profile it is CreativeWork and Trip but Trip should be URL, it will be fixed together with definition as per issue 311 request)
* isBasedOn included range Product that was removed from the profile (as this is the type, we should keep the original ranges already included in schema.org)

Pending: Include href in comments as it is done in the profiles and in schema.org (not sure how to do so in ttl)
@ljgarcia
Copy link
Collaborator Author

ljgarcia commented Aug 3, 2020

@oxgiraldo This is the update for the type (rather than the type). It basically includes the same information as it is in the profile (https://bioschemas.org/profiles/LabProtocol/0.4-DRAFT-2020_07_23/) with minor differences in isPartOf and isBasedOn (see comments above in the PR). Please double check that it is all there. Thanks.

@ljgarcia
Copy link
Collaborator Author

ljgarcia commented Aug 3, 2020

@AlasdairGray schema.org properties were added using ComputationalWorkflow as example. URLs used in the comments, e.g. isPartOf has a link to hasPart) are missing, not sure how to do that in ttl. Thanks.

@ljgarcia
Copy link
Collaborator Author

ljgarcia commented Aug 3, 2020

@AlasdairGray just realized, if a property comes from a parent (CreativeWork and Thing in this case), there is no need to include it. But, if the property is used by the type but does not come from a parent, then we should include it. Am I right? Double checking before modifying the ttl

@oxgiraldo
Copy link

@ljgarcia, review done, thanks.

@AlasdairGray AlasdairGray marked this pull request as draft August 24, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants