-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LabProtocol type acc. to 0.4_DRAFT profile #10
base: BioChemEntity
Are you sure you want to change the base?
Conversation
Changes regarding the 0.4_DRAFT profile: * isPartOf has range CreativeWork and URL (in the profile it is CreativeWork and Trip but Trip should be URL, it will be fixed together with definition as per issue 311 request) * isBasedOn included range Product that was removed from the profile (as this is the type, we should keep the original ranges already included in schema.org) Pending: Include href in comments as it is done in the profiles and in schema.org (not sure how to do so in ttl)
@oxgiraldo This is the update for the type (rather than the type). It basically includes the same information as it is in the profile (https://bioschemas.org/profiles/LabProtocol/0.4-DRAFT-2020_07_23/) with minor differences in isPartOf and isBasedOn (see comments above in the PR). Please double check that it is all there. Thanks. |
@AlasdairGray schema.org properties were added using ComputationalWorkflow as example. URLs used in the comments, e.g. isPartOf has a link to hasPart) are missing, not sure how to do that in ttl. Thanks. |
@AlasdairGray just realized, if a property comes from a parent (CreativeWork and Thing in this case), there is no need to include it. But, if the property is used by the type but does not come from a parent, then we should include it. Am I right? Double checking before modifying the ttl |
Either CreativeWork or Thing
@ljgarcia, review done, thanks. |
Changes regarding the 0.4_DRAFT profile:
New updates included corresponding to 0.5_DRAFT profile:
Pending: Include href in comments as it is done in the profiles and in schema.org (not sure how to do so in ttl)