Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance #17

Closed
deflaux opened this issue Oct 30, 2014 · 8 comments
Closed

improve performance #17

deflaux opened this issue Oct 30, 2014 · 8 comments

Comments

@deflaux
Copy link
Collaborator

deflaux commented Oct 30, 2014

This package is in active development and there are some inefficiencies in a few places (e.g., the code that accumulates multiple pages of variants and reads). But we'll tackle improving performance a bit when the code settles down a bit more.

@pgrosu
Copy link

pgrosu commented Oct 30, 2014

No worries Nicole, it's a team effort - that's what makes it fun :)

@deflaux deflaux mentioned this issue Oct 30, 2014
@siddharthab
Copy link
Collaborator

Going forward, performant access to the API is predicated by using the RPC interface instead of the REST interface:
http://www.grpc.io/
https://cloud.google.com/genomics/reference/rpc/

I am working on writing a running example based on gRPC.

@ttriche
Copy link
Contributor

ttriche commented Jul 7, 2015

Does this mean that Avro is getting canned? And an R gRPC client coming?

AWESO^H^H^H^H^Hthat is an eminently logical implementation decision.

Statistics is the grammar of science.
Karl Pearson http://en.wikipedia.org/wiki/The_Grammar_of_Science

On Mon, Jul 6, 2015 at 4:31 PM, Siddhartha Bagaria <notifications@github.com

wrote:

Going forward, performant access to the API is predicated by using the RPC
interface instead of the REST interface:
http://www.grpc.io/
https://cloud.google.com/genomics/reference/rpc/

I am working on writing a running example based on gRPC.


Reply to this email directly or view it on GitHub
#17 (comment)
.

@siddharthab
Copy link
Collaborator

I am trying to base the gRPC R package on the RProtoBuf package. But there are several changes needed there too. A generic package might be a little farther off but I can get the GoogleGenomics endpoints running soon-ish.

@pgrosu
Copy link

pgrosu commented Jul 7, 2015

Sid, how about just basically writing a wrapper via Rcpp? Autonomy is always more fun :)

Tim, I think it's an evolution :)

@siddharthab
Copy link
Collaborator

Paul, that is what will happen if I base it on the RProtoBuf package. I need the package for the interface to the C protocol buffers library.

@pgrosu
Copy link

pgrosu commented Jul 7, 2015

Gotcha! Super-excited to see what you come up with :)

Thx,
~p

@siddharthab
Copy link
Collaborator

Resolved with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants